From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: Kirill Batuzov <batuzovk@ispras.ru>
Cc: zhur@ispras.ru, qemu-devel@nongnu.org,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [RFC][PATCH v0 0/8] Improve register allocator
Date: Tue, 24 May 2011 15:24:33 +0200 [thread overview]
Message-ID: <BANLkTimhSQFNRq96XYTCWmGQtp_2vg3rzQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1105241423250.2267@bulbul>
On Tue, May 24, 2011 at 1:31 PM, Kirill Batuzov <batuzovk@ispras.ru> wrote:
[...]
> Gathered statistics shows some interesting things too. I've run matrix
> multiplication benchmark (guest - ARM, host - x86, linux-user mode, with
> my patches applied) and here are the results:
>
> spill count 3916
> real spills 32
> spills at bb end 1023
> spills at call:
> globals 2755
> iarg passing 0
> call cloobers 106
>
> Real spills are spills generated by register allocator when it runs out
> of registers. They are less than 1% of all spills. Other tests show
> similar behavior.
When you write "host x86", do you mean IA32 or x86_64?
That might change the number of real spills a lot if you meant
x86_64.
> I think any further improvements to register allocator without leveling
> conventions about saving globals at calls and BB ends somehow is
> useless.
>
> Currently we are looking if we can pass some globals on registers
> through basic block boundaries (inside one TB of course).
If by "basic block", you mean BB as implied by TCG br for
instance, I'm not sure all guests will benefit a lot. If you
mean that you intend on putting several guests BB in a
single TB then I guess you'll have to first collect dynamic
statistics before dynamically switching to grouping BB.
Laurent
next prev parent reply other threads:[~2011-05-24 13:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 14:40 [Qemu-devel] [RFC][PATCH v0 0/8] Improve register allocator Kirill Batuzov
2011-05-23 14:40 ` [Qemu-devel] [RFC][PATCH v0 1/8] Compute additional liveness information for " Kirill Batuzov
2011-05-23 14:40 ` [Qemu-devel] [RFC][PATCH v0 2/8] Propagate REG_NEXT_USE value through process of register allocation Kirill Batuzov
2011-05-23 14:40 ` [Qemu-devel] [RFC][PATCH v0 3/8] Do better spill choice Kirill Batuzov
2011-05-23 14:40 ` [Qemu-devel] [RFC][PATCH v0 4/8] Calculate NEXT_CALL liveness information Kirill Batuzov
2011-05-23 14:40 ` [Qemu-devel] [RFC][PATCH v0 5/8] Track call-clobbered uses of registers Kirill Batuzov
2011-05-23 14:40 ` [Qemu-devel] [RFC][PATCH v0 6/8] Spill globals early if their next use is in call Kirill Batuzov
2011-05-23 14:40 ` [Qemu-devel] [RFC][PATCH v0 7/8] Spill globals early if their next use is at the BB end Kirill Batuzov
2011-05-23 14:40 ` [Qemu-devel] [RFC][PATCH v0 8/8] Add spill count profiling Kirill Batuzov
2011-05-23 19:32 ` Blue Swirl
2011-05-23 21:22 ` [Qemu-devel] [RFC][PATCH v0 0/8] Improve register allocator Aurelien Jarno
2011-05-24 11:31 ` Kirill Batuzov
2011-05-24 12:40 ` Aurelien Jarno
2011-05-24 13:24 ` Laurent Desnogues [this message]
2011-05-24 13:32 ` Kirill Batuzov
2011-05-24 16:07 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimhSQFNRq96XYTCWmGQtp_2vg3rzQ@mail.gmail.com \
--to=laurent.desnogues@gmail.com \
--cc=aurelien@aurel32.net \
--cc=batuzovk@ispras.ru \
--cc=qemu-devel@nongnu.org \
--cc=zhur@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).