From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QMdF8-0007aA-7i
	for qemu-devel@nongnu.org; Wed, 18 May 2011 05:40:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QMdF7-0003cW-AR
	for qemu-devel@nongnu.org; Wed, 18 May 2011 05:40:38 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:37379)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QMdF7-0003ZZ-7c
	for qemu-devel@nongnu.org; Wed, 18 May 2011 05:40:37 -0400
Received: by mail-iw0-f173.google.com with SMTP id 42so1359398iwl.4
	for <qemu-devel@nongnu.org>; Wed, 18 May 2011 02:40:36 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <BANLkTi=zcAG2LjEkzj7CUCfo7EVd9OzLGA@mail.gmail.com>
References: <BANLkTinHhx5jTgcH-cytci=fNdk2V7zssg@mail.gmail.com>
	<BANLkTim6osGVGU8oqpx0ZcOVU17c7LS5AA@mail.gmail.com>
	<BANLkTikodwB2aNsPL42DCk=dq43pg+kKQw@mail.gmail.com>
	<BANLkTinbceD4PVaHabCzYxyT7EtFnTNKtg@mail.gmail.com>
	<4DD38F03.7020209@gmail.com>
	<BANLkTi=zcAG2LjEkzj7CUCfo7EVd9OzLGA@mail.gmail.com>
Date: Wed, 18 May 2011 10:40:36 +0100
Message-ID: <BANLkTimhq1-kLWZT8HFHWG5eze5HMuz7mw@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Konishchev <konishchev@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, stanislav.ievlev@gmail.com

On 18 May 2011 10:40, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 18 May 2011 10:18, Dmitry Konishchev <konishchev@gmail.com> wrote:
>
>> + * Attention! The len must be a multiple of 4 * sizeof(long) due to
>> + * restriction of optimizations in this function.
>
> You could assert() this:
> =C2=A0assert(argc % (4 * sizeof(long)) =3D=3D 0);

s/len/argc/, obviously!

-- PMM