From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37541)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QbDup-0000l5-8H
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 11:40:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QbDum-00005R-NY
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 11:39:59 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:61693)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QbDum-00005K-Ad
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 11:39:56 -0400
Received: by ywb3 with SMTP id 3so2442495ywb.4
	for <qemu-devel@nongnu.org>; Mon, 27 Jun 2011 08:39:55 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4E08925F.3030605@adacore.com>
References: <1309178511-20027-1-git-send-email-chouteau@adacore.com>
	<BANLkTimbSmJxn6QZNbw4uE8Fp0gQt6gocQ@mail.gmail.com>
	<4E08925F.3030605@adacore.com>
Date: Mon, 27 Jun 2011 16:39:55 +0100
Message-ID: <BANLkTimhvpiLadfrus+YefoH5oHBAqOK6w@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64
	bytes minimum
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-devel@nongnu.org

On Mon, Jun 27, 2011 at 3:23 PM, Fabien Chouteau <chouteau@adacore.com> wro=
te:
> On 27/06/2011 15:50, Stefan Hajnoczi wrote:
>> On Mon, Jun 27, 2011 at 1:41 PM, Fabien Chouteau <chouteau@adacore.com> =
wrote:
>>>
>>> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
>>> ---
>>> =A0slirp/slirp.c | =A0 =A04 ++--
>>> =A01 files changed, 2 insertions(+), 2 deletions(-)
>>
>> Any particular bug that this fixes?
>>
>> There have been 64 byte minimum padding patches to several emulated
>> NICs. =A0There has also been discussion about where the best place to do
>> this is. =A0Why is this patch necessary?
>>
>
> This patch is necessary because some NICs are configured to drop short fr=
ames,
> therefore the OS will not receive some of the packets generated by Qemu.
>
> There's a first patch to fix this issue:
> http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=3Ddbf3c4b4baceb91eb6=
4d09f787cbe92d65188813
>
> My patch fixes two other sources of short frames.

Thanks for the explanation.  I stepped back from the discussion on
where the right place to fix this is last time around.  Now I'm
wondering why do anything in slirp when the other sources (tap, ...)
aren't padding to 64 bytes?

Stefan