From: Peter Maydell <peter.maydell@linaro.org>
To: stefano.stabellini@eu.citrix.com
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v2] xen_disk: cope with missing xenstore "params" node
Date: Sat, 25 Jun 2011 23:09:18 +0100 [thread overview]
Message-ID: <BANLkTimjqgtTZDfWSJAO2NXPMZ8S0kA82g@mail.gmail.com> (raw)
In-Reply-To: <1308933348-12022-1-git-send-email-stefano.stabellini@eu.citrix.com>
On 24 June 2011 17:35, <stefano.stabellini@eu.citrix.com> wrote:
> +out_error:
> + qemu_free(blkdev->params);
> + qemu_free(blkdev->mode);
> + qemu_free(blkdev->type);
> + qemu_free(blkdev->dev);
> + qemu_free(blkdev->devtype);
> + return -1;
It occured to me that could result in a double-free if it's
possible to call init again (or to call free) after the init
routine has returned failure. I don't know enough about the
Xen device lifecycle to know if that's possible, though -- is it?
thanks
-- PMM
next prev parent reply other threads:[~2011-06-25 22:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 16:35 [Qemu-devel] [PATCH v2] xen_disk: cope with missing xenstore "params" node stefano.stabellini
2011-06-25 22:09 ` Peter Maydell [this message]
2011-06-27 13:40 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimjqgtTZDfWSJAO2NXPMZ8S0kA82g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).