From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47308)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alexey.zaytsev@gmail.com>) id 1QLf74-0000Do-PY
	for qemu-devel@nongnu.org; Sun, 15 May 2011 13:28:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alexey.zaytsev@gmail.com>) id 1QLf73-00089P-DW
	for qemu-devel@nongnu.org; Sun, 15 May 2011 13:28:18 -0400
Received: from mail-vx0-f173.google.com ([209.85.220.173]:60040)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alexey.zaytsev@gmail.com>) id 1QLf73-00089K-4w
	for qemu-devel@nongnu.org; Sun, 15 May 2011 13:28:17 -0400
Received: by vxb37 with SMTP id 37so3224376vxb.4
	for <qemu-devel@nongnu.org>; Sun, 15 May 2011 10:28:16 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4DD00A02.1010205@web.de>
References: <BANLkTim-Sb4=19sfZkrGnQ_4Nk8WGan1cA@mail.gmail.com>
	<20110515163105.GG24932@redhat.com> <4DD00A02.1010205@web.de>
Date: Sun, 15 May 2011 21:28:16 +0400
Message-ID: <BANLkTimoEG+RyYMwZ644zLuC7uKkb5ok6Q@mail.gmail.com>
From: Alexey Zaytsev <alexey.zaytsev@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] AHCI broken in current git, bisected.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Avi Kivity <avi@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On Sun, May 15, 2011 at 21:14, Jan Kiszka <jan.kiszka@web.de> wrote:
> On 2011-05-15 18:32, Michael S. Tsirkin wrote:
>> On Sun, May 15, 2011 at 07:58:23PM +0400, Alexey Zaytsev wrote:
>>> Hi.
>>>
>>> The commit 667bb59d2358daeef179583c944becba3f1f9680
>>> Author: Avi Kivity <avi@redhat.com>
>>> Date: =C2=A0 Mon Apr 4 18:28:02 2011 +0300
>>>
>>> =C2=A0 =C2=A0 ich/ahci: convert to pci_register_bar_simple()
>>>
>>> =C2=A0 =C2=A0 Signed-off-by: Avi Kivity <avi@redhat.com>
>>> =C2=A0 =C2=A0 Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>>
>>> breaks AHCI to the point the disks are not detected by both seabios and=
 Linux:
>>>
>>> [ =C2=A0 =C2=A08.582220] ata1: PATA max MWDMA2 cmd 0x1f0 ctl 0x3f6 bmdm=
a 0xc000 irq 14
>>> [ =C2=A0 =C2=A08.582646] ata2: PATA max MWDMA2 cmd 0x170 ctl 0x376 bmdm=
a 0xc008 irq 15
>>> [ =C2=A0 =C2=A08.603979] ACPI: PCI Interrupt Link [LNKD] enabled at IRQ=
 10
>>> [ =C2=A0 =C2=A08.605151] ahci 0000:00:04.0: PCI INT A -> Link[LNKD] -> =
GSI 10
>>> (level, high) -> IRQ 10
>>> [ =C2=A0 =C2=A09.608243] ahci 0000:00:04.0: controller reset failed (0x=
f000ff53)
>>> [ =C2=A0 =C2=A09.609948] ahci 0000:00:04.0: PCI INT A disabled
>>> [ =C2=A0 =C2=A09.610267] ahci: probe of 0000:00:04.0 failed with error =
-5
>>
>> Sure enough,
>>
>> =C2=A0 =C2=A0 /* XXX BAR size should be 1k, but that breaks, so bump it =
to 4k for now */
>> =C2=A0 =C2=A0 pci_register_bar_simple(&d->card, 5, 0x1000, 0, d->ahci.me=
m);
>> =C2=A0 =C2=A0 msi_init(dev, 0x50, 1, true, false);
>> =C2=A0 =C2=A0 ahci_init(&d->ahci, &dev->qdev, 6);
>>
>> where ahci_init initializes d->ahci.mem.
>>
>> Coul;d you try out the following please
>> (untested, a bit busy now)?
>
> See also http://permalink.gmane.org/gmane.comp.emulators.qemu/101978
>

Hey, thanks! I should look harder next time. ;)