From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36586)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony.perard@gmail.com>) id 1QcOnZ-0006iI-Rv
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 17:29:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony.perard@gmail.com>) id 1QcOnQ-0000ly-Gb
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 17:29:20 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:44351)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony.perard@gmail.com>) id 1QcOnP-0000lX-Si
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 17:29:12 -0400
Received: by pvg3 with SMTP id 3so2434757pvg.4
	for <qemu-devel@nongnu.org>; Thu, 30 Jun 2011 14:29:10 -0700 (PDT)
MIME-Version: 1.0
Sender: anthony.perard@gmail.com
In-Reply-To: <BANLkTinkV=ADwVOWTjt0UbF3-BfcX8bEwA@mail.gmail.com>
References: <1309462094-12348-1-git-send-email-anthony.perard@citrix.com>
	<BANLkTinkV=ADwVOWTjt0UbF3-BfcX8bEwA@mail.gmail.com>
From: Anthony PERARD <anthony.perard@citrix.com>
Date: Thu, 30 Jun 2011 22:28:40 +0100
Message-ID: <BANLkTimpFWHSuvm3PEbkOmJ0ykL0jYD1+g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2] e1000: Handle IO Port.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU-devel <qemu-devel@nongnu.org>

On Thu, Jun 30, 2011 at 22:09, Peter Maydell <peter.maydell@linaro.org> wro=
te:
> On 30 June 2011 20:28, Anthony PERARD <anthony.perard@citrix.com> wrote:
>> @@ -202,6 +201,11 @@ rxbufsize(uint32_t v)
>> =C2=A0static void
>> =C2=A0set_ctrl(E1000State *s, int index, uint32_t val)
>> =C2=A0{
>> + =C2=A0 =C2=A0DBGOUT(IO, "set ctrl =3D %08x\n", val);
>> + =C2=A0 =C2=A0if (val & E1000_CTRL_RST) {
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0s->mac_reg[CTRL] =3D val;
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0e1000_reset(s);
>> + =C2=A0 =C2=A0}
>> =C2=A0 =C2=A0 /* RST is self clearing */
>> =C2=A0 =C2=A0 s->mac_reg[CTRL] =3D val & ~E1000_CTRL_RST;
>> =C2=A0}
>
> This is still not right -- you want something like:

:(, sorry, I'll resend the patch with that.

> =C2=A0 =C2=A0if (val & E1000_CTRL_RST) {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0e1000_reset(s);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0return;
> =C2=A0 =C2=A0}
> =C2=A0 =C2=A0s->mac_reg[CTRL] =3D val;

Thanks,

--=20
Anthony PERARD