[Qemu-devel] No scratch directory in qemu-iotests

[Qemu-devel] No scratch directory in qemu-iotests

[Lyu Mitnick]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hello

When I want to use qemu-iotests, some error occurred:

$ git clone git://
git.kernel.org/pub/scm/linux/kernel/git/hch/qemu-iotests.git

$ cd qemu-iotests

$ ./check -h
common.config: Error: $TEST_DIR
(/home/mitnick/Desktop/GSoC2011/QEMU/qemu-iotests/scratch) is not a
directory

There is no error when I create directory scratch. I am wondering whether
scratch
should be add into qemu-iotests master tree??

Thanks

Mitnick

[-- Attachment #2: Type: text/html, Size: 706 bytes --]

Re: [Qemu-devel] No scratch directory in qemu-iotests

[Stefan Hajnoczi]

On Fri, Apr 08, 2011 at 09:21:02AM +0800, Lyu Mitnick wrote:
> Hello
>
> When I want to use qemu-iotests, some error occurred:
>
> $ git clone git://
> git.kernel.org/pub/scm/linux/kernel/git/hch/qemu-iotests.git
>
> $ cd qemu-iotests
>
> $ ./check -h
> common.config: Error: $TEST_DIR
> (/home/mitnick/Desktop/GSoC2011/QEMU/qemu-iotests/scratch) is not a
> directory
>
> There is no error when I create directory scratch. I am wondering whether
> scratch
> should be add into qemu-iotests master tree??

I think it's a good idea to make qemu-iotests work out-of-the-box.
Can you send a patch for this?

Note that scratch/ is in .gitignore so you might have to tweak
.gitignore to get the behavior you want.  Alternatively common.config
could mkdir scratch/ on first run.

Stefan

Re: [Qemu-devel] No scratch directory in qemu-iotests

[Christoph Hellwig]

On Fri, Apr 08, 2011 at 09:47:47AM +0100, Stefan Hajnoczi wrote:
> I think it's a good idea to make qemu-iotests work out-of-the-box.
> Can you send a patch for this?
> 
> Note that scratch/ is in .gitignore so you might have to tweak
> .gitignore to get the behavior you want.  Alternatively common.config
> could mkdir scratch/ on first run.

Hmm.  The original idea was you make it a symlink to a partitions so that you
don't have to nessecarily run it inside the source tree. But I suspect just
include the directory and allowing an override is fine, too.