From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59612 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6LNT-0000Bk-Nb
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 07:22:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Q6LNO-00018M-Kr
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 07:21:55 -0400
Received: from mail-vx0-f173.google.com ([209.85.220.173]:32768)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Q6LNO-00017o-Ho
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 07:21:50 -0400
Received: by vxb41 with SMTP id 41so4138052vxb.4
	for <qemu-devel@nongnu.org>; Sun, 03 Apr 2011 04:21:49 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <BANLkTi=89=Lsq0NjuJkgqgHhD_eKuK123g@mail.gmail.com>
References: <1301668243-29886-1-git-send-email-peter.maydell@linaro.org>
	<1301668243-29886-2-git-send-email-peter.maydell@linaro.org>
	<AANLkTinLgJDOaaMQft_gMpGjOgmZ33ojB+GV6kfPh9pY@mail.gmail.com>
	<AANLkTimMiHupSuDJdfOtpfrn9Ou_hRH=FtemGC+Y+DpK@mail.gmail.com>
	<BANLkTi=Arv9QE5t0jXW3WjCrjmvkjaG1mg@mail.gmail.com>
	<BANLkTin4o2NXVty8MsmYpmw3VVom4BrC+Q@mail.gmail.com>
	<BANLkTi=89=Lsq0NjuJkgqgHhD_eKuK123g@mail.gmail.com>
Date: Sun, 3 Apr 2011 12:21:49 +0100
Message-ID: <BANLkTimzh5VwSH_wemreFWL2o0A5QK+Zfg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper routines
	use correct FP status
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org

On 3 April 2011 12:10, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Sun, Apr 3, 2011 at 1:51 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> But I can submit a patch to do that if it's the right thing.
>
> It's not so much about correctness, but performance. All generated
> code already has access to global env, so passing it via helper
> arguments requires extra instructions which can be avoided.

Yes; I meant "right thing" in the more general senses of "is best
practice for qemu code" and "causes my patches to be accepted" :-)

Anyway, how about I do a version of this patch which moves
the affected neon helpers to op_helper.c rather than adding
an env parameter (which would avoid changes that a cleanup
would just have to revert); but leave patch 10 as-is (that's
the one which is touching vfp helpers, but it is just cleanup
which isn't changing how they handle env) ?

Then I can do a separate patchset to move other helpers,
rather than tangling a code-cleanup patchset with Neon
correctness fixes.

-- PMM