From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37320)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <konishchev@gmail.com>) id 1QWkgJ-0005LQ-KO
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 03:38:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <konishchev@gmail.com>) id 1QWkgH-0005Bz-V3
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 03:38:31 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:62568)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <konishchev@gmail.com>) id 1QWkgH-0005Bf-HX
	for qemu-devel@nongnu.org; Wed, 15 Jun 2011 03:38:29 -0400
Received: by bwz16 with SMTP id 16so273135bwz.4
	for <qemu-devel@nongnu.org>; Wed, 15 Jun 2011 00:38:27 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <BANLkTimJWWLb15tNbSuEbnONV3E34QSt_A@mail.gmail.com>
References: <1307544625-22907-1-git-send-email-konishchev@gmail.com>
	<20110613082608.GA25582@stefanha-thinkpad.localdomain>
	<BANLkTimTipnCL5h-S2LYm85cAn=zSyqcGg@mail.gmail.com>
	<BANLkTimTrwLRnpqUt4XnMgYQNyQphzmphA@mail.gmail.com>
	<BANLkTimJWWLb15tNbSuEbnONV3E34QSt_A@mail.gmail.com>
Date: Wed, 15 Jun 2011 11:38:27 +0400
Message-ID: <BANLkTin-wmBn1DiriRpcK-g64fYDiv-uxA@mail.gmail.com>
From: Dmitry Konishchev <konishchev@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img
 convert' using bdrv_is_allocated()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

On Tue, Jun 14, 2011 at 7:58 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote=
:
> Yes, please.

OK, I'll do it as soon I'll find time for it.


On Tue, Jun 14, 2011 at 7:58 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote=
:
> For image files the block layer should be caching the device capacity (si=
ze)
> anyway, so you probably don't need to allocate the array, just call
> bdrv_get_geometry().  That might make it easier to write a self-contained
> function.

I've tried to not cache, but it turned out that bdrv_get_geometry()
calls are quite noticeable in profiler without caching.

--=20
=D0=94=D0=BC=D0=B8=D1=82=D1=80=D0=B8=D0=B9 =D0=9A=D0=BE=D0=BD=D0=B8=D1=89=
=D0=B5=D0=B2 (Dmitry Konishchev)
mailto:konishchev@gmail.com