From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QK5Zy-00033Y-70 for qemu-devel@nongnu.org; Wed, 11 May 2011 05:19:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QK5Zw-0000Fp-W4 for qemu-devel@nongnu.org; Wed, 11 May 2011 05:19:38 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:64799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QK5Zw-0000Fl-SF for qemu-devel@nongnu.org; Wed, 11 May 2011 05:19:36 -0400 Received: by ywl41 with SMTP id 41so115824ywl.4 for ; Wed, 11 May 2011 02:19:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 11 May 2011 10:19:36 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Add warmup phase for live migration of large memory apps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Shribman, Aidan" Cc: "qemu-devel@nongnu.org" On Wed, May 11, 2011 at 8:58 AM, Shribman, Aidan w= rote: > From: Aidan Shribman > > [PATCH] Add warmup phase for live migration of large memory apps > > By invoking "migrate -w " we initiate a background live-migration > transferring of dirty pages continuously until invocation of "migrate_end= " > which attempts to complete the live migration operation. What is the purpose of this patch? How and when do I use it? Some nitpicks: > @@ -81,6 +83,11 @@ int do_migrate(Monitor *mon, const QDict *qdict, QObje= ct **ret_data) > =A0 =A0 int blk =3D qdict_get_try_bool(qdict, "blk", 0); > =A0 =A0 int inc =3D qdict_get_try_bool(qdict, "inc", 0); > =A0 =A0 const char *uri =3D qdict_get_str(qdict, "uri"); > + =A0 =A0is_migrate_warmup =3D qdict_get_try_bool(qdict, "warmup", 0); > + > + =A0 =A0if (is_migrate_warmup) { > + =A0 =A0 =A0 =A0detach =3D 1; /* as we need migrate_end to complte */ s/complte/complete/ > + =A0 =A0 =A0 } Please follow the coding style and put the closing curly brace on the same column as the 'if' statement. > +int qemu_savevm_state_warmup(Monitor *mon, QEMUFile *f) { > + =A0 =A0int ret =3D 1; 1 is overwritten immediately. Stefan