From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59089)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QV4hc-00054j-5J
	for qemu-devel@nongnu.org; Fri, 10 Jun 2011 12:36:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QV4ha-0005pa-Pm
	for qemu-devel@nongnu.org; Fri, 10 Jun 2011 12:36:55 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:65110)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QV4ha-0005pK-6v
	for qemu-devel@nongnu.org; Fri, 10 Jun 2011 12:36:54 -0400
Received: by pzk30 with SMTP id 30so1369732pzk.4
	for <qemu-devel@nongnu.org>; Fri, 10 Jun 2011 09:36:52 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <is5hq7$gdl$1@dough.gmane.org>
References: <1306932992-30075-1-git-send-email-cfergeau@redhat.com>
	<1306932992-30075-2-git-send-email-cfergeau@redhat.com>
	<is5hq7$gdl$1@dough.gmane.org>
Date: Fri, 10 Jun 2011 17:36:52 +0100
Message-ID: <BANLkTin80PjFuVUCNfYjkmqc=yU5rdmuBQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/3] lsi: Fix unused-but-set-variable
	warning
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Stefan, if you're picking up gcc warning fixes for the trivial
tree, how about this one?

(I think the other gcc warning fixes are either:
 * in the most recent usb pull request
 * linux-user
 * target-alpha
which all have a clear owner/interested person.)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

On 1 June 2011 15:19, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 06/01/2011 02:56 PM, Christophe Fergeau wrote:
>>
>> This warning is new in gcc 4.6.
>>
>> Signed-off-by: Christophe Fergeau<cfergeau@redhat.com>
>> ---
>> =C2=A0hw/lsi53c895a.c | =C2=A0 =C2=A02 --
>> =C2=A01 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
>> index 83084b6..90c6cbc 100644
>> --- a/hw/lsi53c895a.c
>> +++ b/hw/lsi53c895a.c
>> @@ -889,7 +889,6 @@ static void lsi_do_msgout(LSIState *s)
>> =C2=A0 =C2=A0 =C2=A0uint8_t msg;
>> =C2=A0 =C2=A0 =C2=A0int len;
>> =C2=A0 =C2=A0 =C2=A0uint32_t current_tag;
>> - =C2=A0 =C2=A0SCSIDevice *current_dev;
>> =C2=A0 =C2=A0 =C2=A0lsi_request *current_req, *p, *p_next;
>> =C2=A0 =C2=A0 =C2=A0int id;
>>
>> @@ -901,7 +900,6 @@ static void lsi_do_msgout(LSIState *s)
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0current_req =3D lsi_find_by_tag(s, cur=
rent_tag);
>> =C2=A0 =C2=A0 =C2=A0}
>> =C2=A0 =C2=A0 =C2=A0id =3D (current_tag>> =C2=A08)& =C2=A00xf;
>> - =C2=A0 =C2=A0current_dev =3D s->bus.devs[id];
>>
>> =C2=A0 =C2=A0 =C2=A0DPRINTF("MSG out len=3D%d\n", s->dbc);
>> =C2=A0 =C2=A0 =C2=A0while (s->dbc) {
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>