From: Stefan Hajnoczi <stefanha@gmail.com>
To: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Cc: jvrao@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v4] v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0.
Date: Tue, 5 Apr 2011 13:27:57 +0100 [thread overview]
Message-ID: <BANLkTin=rDS4uftnMtb3kCHCVXfo2cQmcQ@mail.gmail.com> (raw)
In-Reply-To: <1301999735-24141-1-git-send-email-harsh@linux.vnet.ibm.com>
On Tue, Apr 5, 2011 at 11:35 AM, Harsh Prateek Bora
<harsh@linux.vnet.ibm.com> wrote:
> The nwnames field in TWALK message is assumed to be >=0 and <= MAXWELEM
> which is defined as macro P9_MAXWELEM (16) in virtio-9p.h as per 9p2000
> RFC. Appropriate changes are required in V9fsWalkState and v9fs_walk.
>
> v4:
> - rebased on mainline repo, else condition updated as required.
>
> v3:
> - Updated if-else conditions to appropriately handle nwnames = 0.
>
> v2:
> - Added check in v9fs_walk_complete as well.
>
> Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
> ---
> hw/virtio-9p.c | 7 +++++--
> hw/virtio-9p.h | 2 +-
> 2 files changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
prev parent reply other threads:[~2011-04-05 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 10:35 [Qemu-devel] [PATCH v4] v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0 Harsh Prateek Bora
2011-04-05 12:27 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTin=rDS4uftnMtb3kCHCVXfo2cQmcQ@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=harsh@linux.vnet.ibm.com \
--cc=jvrao@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).