From: Christian Brunner <chb@muc.de>
To: Josh Durgin <josh.durgin@dreamhost.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
ceph-devel@vger.kernel.org, qemu-devel@nongnu.org,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v4 4/4] rbd: Add bdrv_truncate implementation
Date: Wed, 25 May 2011 21:22:04 +0200 [thread overview]
Message-ID: <BANLkTinBv5OG5obL8V89aahR85-8s8KnsQ@mail.gmail.com> (raw)
In-Reply-To: <1306263078-18089-5-git-send-email-josh.durgin@dreamhost.com>
Looks good to me:
Reviewed-by: Christian Brunner <chb@muc.de>
2011/5/24 Josh Durgin <josh.durgin@dreamhost.com>:
> Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
> ---
> block/rbd.c | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index c9f32e4..015ae8e 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -687,6 +687,20 @@ static int64_t qemu_rbd_getlength(BlockDriverState *bs)
> return info.size;
> }
>
> +static int qemu_rbd_truncate(BlockDriverState *bs, int64_t offset)
> +{
> + BDRVRBDState *s = bs->opaque;
> + int r;
> +
> + r = rbd_resize(s->image, offset);
> + if (r < 0) {
> + error_report("failed to resize rbd image");
> + return -EIO;
> + }
> +
> + return 0;
> +}
> +
> static int qemu_rbd_snap_create(BlockDriverState *bs,
> QEMUSnapshotInfo *sn_info)
> {
> @@ -785,6 +799,7 @@ static BlockDriver bdrv_rbd = {
> .bdrv_get_info = qemu_rbd_getinfo,
> .create_options = qemu_rbd_create_options,
> .bdrv_getlength = qemu_rbd_getlength,
> + .bdrv_truncate = qemu_rbd_truncate,
> .protocol_name = "rbd",
>
> .bdrv_aio_readv = qemu_rbd_aio_readv,
> --
> 1.7.2.3
>
>
>
prev parent reply other threads:[~2011-05-25 19:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 18:51 [Qemu-devel] [PATCH v4 0/4] rbd improvements Josh Durgin
2011-05-24 18:51 ` [Qemu-devel] [PATCH v4 1/4] rbd: use the higher level librbd instead of just librados Josh Durgin
2011-05-25 19:18 ` Christian Brunner
2011-05-25 20:46 ` Josh Durgin
2011-05-24 18:51 ` [Qemu-devel] [PATCH v4 2/4] rbd: allow configuration of rados from the rbd filename Josh Durgin
2011-05-25 19:19 ` Christian Brunner
2011-05-24 18:51 ` [Qemu-devel] [PATCH v4 3/4] rbd: check return values when scheduling aio Josh Durgin
2011-05-25 19:21 ` Christian Brunner
2011-05-24 18:51 ` [Qemu-devel] [PATCH v4 4/4] rbd: Add bdrv_truncate implementation Josh Durgin
2011-05-25 19:22 ` Christian Brunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinBv5OG5obL8V89aahR85-8s8KnsQ@mail.gmail.com \
--to=chb@muc.de \
--cc=ceph-devel@vger.kernel.org \
--cc=josh.durgin@dreamhost.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).