From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53179)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <c.m.brunner@gmail.com>) id 1QPJeg-0002gt-RA
	for qemu-devel@nongnu.org; Wed, 25 May 2011 15:22:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <c.m.brunner@gmail.com>) id 1QPJef-0003rw-He
	for qemu-devel@nongnu.org; Wed, 25 May 2011 15:22:06 -0400
Received: from mail-vx0-f173.google.com ([209.85.220.173]:33939)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <c.m.brunner@gmail.com>) id 1QPJef-0003rp-DK
	for qemu-devel@nongnu.org; Wed, 25 May 2011 15:22:05 -0400
Received: by vxb37 with SMTP id 37so6931820vxb.4
	for <qemu-devel@nongnu.org>; Wed, 25 May 2011 12:22:05 -0700 (PDT)
MIME-Version: 1.0
Sender: c.m.brunner@gmail.com
In-Reply-To: <1306263078-18089-5-git-send-email-josh.durgin@dreamhost.com>
References: <1306263078-18089-1-git-send-email-josh.durgin@dreamhost.com>
	<1306263078-18089-5-git-send-email-josh.durgin@dreamhost.com>
Date: Wed, 25 May 2011 21:22:04 +0200
Message-ID: <BANLkTinBv5OG5obL8V89aahR85-8s8KnsQ@mail.gmail.com>
From: Christian Brunner <chb@muc.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 4/4] rbd: Add bdrv_truncate
	implementation
Reply-To: chb@muc.de
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Josh Durgin <josh.durgin@dreamhost.com>
Cc: Kevin Wolf <kwolf@redhat.com>, ceph-devel@vger.kernel.org, qemu-devel@nongnu.org, kvm@vger.kernel.org

Looks good to me:

Reviewed-by: Christian Brunner <chb@muc.de>


2011/5/24 Josh Durgin <josh.durgin@dreamhost.com>:
> Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
> ---
> =A0block/rbd.c | =A0 15 +++++++++++++++
> =A01 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index c9f32e4..015ae8e 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -687,6 +687,20 @@ static int64_t qemu_rbd_getlength(BlockDriverState *=
bs)
> =A0 =A0 return info.size;
> =A0}
>
> +static int qemu_rbd_truncate(BlockDriverState *bs, int64_t offset)
> +{
> + =A0 =A0BDRVRBDState *s =3D bs->opaque;
> + =A0 =A0int r;
> +
> + =A0 =A0r =3D rbd_resize(s->image, offset);
> + =A0 =A0if (r < 0) {
> + =A0 =A0 =A0 =A0error_report("failed to resize rbd image");
> + =A0 =A0 =A0 =A0return -EIO;
> + =A0 =A0}
> +
> + =A0 =A0return 0;
> +}
> +
> =A0static int qemu_rbd_snap_create(BlockDriverState *bs,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 QEMUSnaps=
hotInfo *sn_info)
> =A0{
> @@ -785,6 +799,7 @@ static BlockDriver bdrv_rbd =3D {
> =A0 =A0 .bdrv_get_info =A0 =A0 =A0=3D qemu_rbd_getinfo,
> =A0 =A0 .create_options =A0 =A0 =3D qemu_rbd_create_options,
> =A0 =A0 .bdrv_getlength =A0 =A0 =3D qemu_rbd_getlength,
> + =A0 =A0.bdrv_truncate =A0 =A0 =A0=3D qemu_rbd_truncate,
> =A0 =A0 .protocol_name =A0 =A0 =A0=3D "rbd",
>
> =A0 =A0 .bdrv_aio_readv =A0 =A0 =3D qemu_rbd_aio_readv,
> --
> 1.7.2.3
>
>
>