From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45294)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QSmOw-0006av-Kc
	for qemu-devel@nongnu.org; Sat, 04 Jun 2011 04:40:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QSmOu-00056d-Et
	for qemu-devel@nongnu.org; Sat, 04 Jun 2011 04:40:10 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:38722)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QSmOu-00056Z-4Y
	for qemu-devel@nongnu.org; Sat, 04 Jun 2011 04:40:08 -0400
Received: by qyk10 with SMTP id 10so1342668qyk.4
	for <qemu-devel@nongnu.org>; Sat, 04 Jun 2011 01:40:07 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1306982755-19553-1-git-send-email-cerbere@gmail.com>
References: <1306982755-19553-1-git-send-email-cerbere@gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 4 Jun 2011 11:39:47 +0300
Message-ID: <BANLkTinC8b2TULzmr5be+W+9xBsA-yoYug@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH] Darwin: Fix compilation warning
 regarding the deprecated daemon() function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexandre Raymond <cerbere@gmail.com>
Cc: andreas.faerber@web.de, qemu-devel@nongnu.org

On Thu, Jun 2, 2011 at 5:45 AM, Alexandre Raymond <cerbere@gmail.com> wrote=
:
> On OSX > 10.5, daemon() is deprecated, resulting int he following warning=
:
> ----8<----
> qemu-nbd.c: In function =E2=80=98main=E2=80=99:
> qemu-nbd.c:371: warning: =E2=80=98daemon=E2=80=99 is deprecated (declared=
 at /usr/include/stdlib.h:289)
> ----8<----
>
> The following trick, used in mDNSResponder, takes care of this warning:
> http://www.opensource.apple.com/source/mDNSResponder/mDNSResponder-258.18=
/mDNSPosix/PosixDaemon.c
>
> Signed-off-by: Alexandre Raymond <cerbere@gmail.com>
> ---
> =C2=A0qemu-nbd.c | =C2=A0 =C2=A09 +++++++++
> =C2=A01 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index e858033..10b0791 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -16,6 +16,10 @@
> =C2=A0* =C2=A0along with this program; if not, see <http://www.gnu.org/li=
censes/>.
> =C2=A0*/
>
> +#if __APPLE__
> +#define daemon fake_daemon_function
> +#endif
> +
> =C2=A0#include <qemu-common.h>
> =C2=A0#include "block_int.h"
> =C2=A0#include "nbd.h"
> @@ -32,6 +36,11 @@
> =C2=A0#include <signal.h>
> =C2=A0#include <libgen.h>
>
> +#if __APPLE__
> +#undef daemon
> +extern int daemon(int, int);
> +#endif
> +

Please introduce a wrapper instead, for example in oslib-posix.c. Then
the #ifdeffery is not spread to generic files.