From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Allow nested qemu_bh_poll() after BH deletion
Date: Wed, 15 Jun 2011 13:04:39 +0100 [thread overview]
Message-ID: <BANLkTinDtFs8NTyqiso0Mf6pWywKanyFmg@mail.gmail.com> (raw)
In-Reply-To: <1308133997-4721-1-git-send-email-kwolf@redhat.com>
On Wed, Jun 15, 2011 at 11:33 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> Without this, qemu segfaults when a BH handler first deletes its BH and
> then calls another function which involves a nested qemu_bh_poll() call.
>
> This can be reproduced by generating an I/O error (e.g. with blkdebug) on
> an IDE device and using rerror/werror=stop to stop the VM. When continuing
> the VM, qemu segfaults.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> async.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
Almost worth switching to qemu-queue.h and FOREACH_SAFE().
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
prev parent reply other threads:[~2011-06-15 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 10:33 [Qemu-devel] [PATCH] Allow nested qemu_bh_poll() after BH deletion Kevin Wolf
2011-06-15 12:04 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinDtFs8NTyqiso0Mf6pWywKanyFmg@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).