From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWopw-00075x-03 for qemu-devel@nongnu.org; Wed, 15 Jun 2011 08:04:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWops-0004Jh-He for qemu-devel@nongnu.org; Wed, 15 Jun 2011 08:04:43 -0400 Received: from mail-yi0-f45.google.com ([209.85.218.45]:63369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWops-0004JT-67 for qemu-devel@nongnu.org; Wed, 15 Jun 2011 08:04:40 -0400 Received: by yia25 with SMTP id 25so241845yia.4 for ; Wed, 15 Jun 2011 05:04:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1308133997-4721-1-git-send-email-kwolf@redhat.com> References: <1308133997-4721-1-git-send-email-kwolf@redhat.com> Date: Wed, 15 Jun 2011 13:04:39 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Allow nested qemu_bh_poll() after BH deletion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Wed, Jun 15, 2011 at 11:33 AM, Kevin Wolf wrote: > Without this, qemu segfaults when a BH handler first deletes its BH and > then calls another function which involves a nested qemu_bh_poll() call. > > This can be reproduced by generating an I/O error (e.g. with blkdebug) on > an IDE device and using rerror/werror=3Dstop to stop the VM. When continu= ing > the VM, qemu segfaults. > > Signed-off-by: Kevin Wolf > --- > =A0async.c | =A0 =A05 +++-- > =A01 files changed, 3 insertions(+), 2 deletions(-) Almost worth switching to qemu-queue.h and FOREACH_SAFE(). Reviewed-by: Stefan Hajnoczi