From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40121 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6ltp-0007hD-Ly for qemu-devel@nongnu.org; Mon, 04 Apr 2011 11:41:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6lto-0004zA-0p for qemu-devel@nongnu.org; Mon, 04 Apr 2011 11:41:04 -0400 Received: from mail-vx0-f173.google.com ([209.85.220.173]:60414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6ltn-0004z5-Sf for qemu-devel@nongnu.org; Mon, 04 Apr 2011 11:41:03 -0400 Received: by vxb41 with SMTP id 41so4873265vxb.4 for ; Mon, 04 Apr 2011 08:41:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4D99DA0B.2020209@suse.de> References: <1301915362-2626-1-git-send-email-peter.maydell@linaro.org> <4D99DA0B.2020209@suse.de> Date: Mon, 4 Apr 2011 16:41:02 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] Re: [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, Aurelien Jarno On 4 April 2011 15:47, Alexander Graf wrote: > On 04/04/2011 01:09 PM, Peter Maydell wrote: >> >> CPU_QuadU isn't used on all targets, but there's no harm in defining the >> typedef anyway. It only needs to be guarded by CONFIG_SOFTFLOAT, because >> softfloat-native doesn't have a float128 type. This avoids the need for >> every new target which uses CPU_QuadU to add itself to an #ifdef in >> what ought to be target-agnostic code. >> >> Signed-off-by: Peter Maydell > > I don't really know my way around FP, but from here it looks good :). Not > sure about the arm part, but I trust Peter on that one ;). The __arm__ part of the ifdef was a voodoo-copy from the CPU_DoubleU typedef, where it actually does matter if you're building a softfloat-native target on an ARM host which uses the ancient FPA floating point ABI (as the comment says, although ARM is generally little-endian doubles are stored in memory in big-endian order under FPA; the more modern VFP has them little-endian). This ifdef condition was meaningless for CPU_QuadU (because FPA didn't have a 128 bit native float type for the type to try to be compatible with) and could never have kicked in anyhow because we wouldn't have compiled unless CONFIG_SOFTFLOAT was defined. -- PMM