From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMd68-0004XO-Bw for qemu-devel@nongnu.org; Wed, 18 May 2011 05:31:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMd67-0002PW-C3 for qemu-devel@nongnu.org; Wed, 18 May 2011 05:31:20 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:34696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMd67-0002PS-9b for qemu-devel@nongnu.org; Wed, 18 May 2011 05:31:19 -0400 Received: by gwb19 with SMTP id 19so537127gwb.4 for ; Wed, 18 May 2011 02:31:18 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1305661431-21289-6-git-send-email-jvrao@linux.vnet.ibm.com> References: <1305661431-21289-1-git-send-email-jvrao@linux.vnet.ibm.com> <1305661431-21289-6-git-send-email-jvrao@linux.vnet.ibm.com> Date: Wed, 18 May 2011 10:31:18 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [V2 05/25] [virtio-9p] Move errno into v9fs_do_readlink List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Venkateswararao Jujjuri (JV)" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On Tue, May 17, 2011 at 8:43 PM, Venkateswararao Jujjuri (JV) wrote: > Signed-off-by: Venkateswararao Jujjuri " > --- > =A0hw/9pfs/virtio-9p.c | =A0 32 ++++++++++++++++---------------- > =A01 files changed, 16 insertions(+), 16 deletions(-) Please see my comment from v1: "The len argument is redundant and not used by any callers, please just return -errno and drop the len argument. Callers rely on buf->size instead." Stefan