From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35372)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QNNjz-0000i8-Up
	for qemu-devel@nongnu.org; Fri, 20 May 2011 07:19:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QNNjz-0007YN-09
	for qemu-devel@nongnu.org; Fri, 20 May 2011 07:19:35 -0400
Received: from mail-iy0-f173.google.com ([209.85.210.173]:61659)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QNNjy-0007YI-OF
	for qemu-devel@nongnu.org; Fri, 20 May 2011 07:19:34 -0400
Received: by iym10 with SMTP id 10so3357287iym.4
	for <qemu-devel@nongnu.org>; Fri, 20 May 2011 04:19:34 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <m3sjsevay8.fsf@blackfin.pond.sub.org>
References: <m3sjsevay8.fsf@blackfin.pond.sub.org>
Date: Fri, 20 May 2011 12:19:33 +0100
Message-ID: <BANLkTinM3s8CA05KfXASmyfB-WN7DrJ3rQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] Regression "Warning: more nics requested than this
	machine supports"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On 16 May 2011 17:58, Markus Armbruster <armbru@redhat.com> wrote:
> =C2=A0 =C2=A0$ qemu-system-x86_64 -nodefaults -enable-kvm -m 384 -vnc :0 =
-S -netdev user,id=3Dnet0 -device e1000,netdev=3Dnet0
> =C2=A0 =C2=A0Warning: more nics requested than this machine supports; som=
e have been ignored
> =C2=A0 =C2=A0(qemu) info network
> =C2=A0 =C2=A0Devices not on any VLAN:
> =C2=A0 =C2=A0 =C2=A0net0: net=3D10.0.2.0, restricted=3Dn peer=3De1000.0
> =C2=A0 =C2=A0 =C2=A0e1000.0: model=3De1000,macaddr=3D52:54:00:12:34:56 pe=
er=3Dnet0
>
> Culprit is
> =C2=A0 =C2=A0net: Improve the warnings for dubious command line option co=
mbinations

> Its count of requested NICs is blissfully unaware of -device. =C2=A0In my
> example, it comes up with nb_nics =3D=3D 0 and seen_nics =3D=3D 1.

As far as I can determine, "-device e1000,netdev=3D0" doesn't go through
net_init_nic() and doesn't put an entry in the nd_table[] for the NIC.
This means it's broken, because a lot of board models look in nd_table[]
to determine whether the user requested a NIC and whether it's the right
type. So I think that in some ways this is just showing up an existing
problem with trying to instantiate a network card with -device.

-- PMM