qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Fix build error in usb-ccid code
@ 2011-04-04 12:31 Dmitry Eremin-Solenikov
  2011-04-04 12:34 ` Peter Maydell
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Eremin-Solenikov @ 2011-04-04 12:31 UTC (permalink / raw)
  To: qemu-devel

W/o this fix I'm getting the following error:
cc1: warnings being treated as errors
hw/usb-ccid.c: In function ‘ccid_card_card_error’:
hw/usb-ccid.c:1202:5: error: format ‘%lX’ expects type ‘long unsigned int’, but argument 2 has type ‘uint64_t’

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 hw/usb-ccid.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/usb-ccid.c b/hw/usb-ccid.c
index 723b2e3..5c80cbd 100644
--- a/hw/usb-ccid.c
+++ b/hw/usb-ccid.c
@@ -1199,7 +1199,7 @@ void ccid_card_card_error(CCIDCardState *card, uint64_t error)
 
     s->bmCommandStatus = COMMAND_STATUS_FAILED;
     s->last_answer_error = error;
-    DPRINTF(s, 1, "VSC_Error: %lX\n", s->last_answer_error);
+    DPRINTF(s, 1, "VSC_Error: %LX\n", s->last_answer_error);
     /* TODO: these error's should be more verbose and propogated to the guest.*/
     /*
      * We flush all pending answers on CardRemove message in ccid-card-passthru,
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] Fix build error in usb-ccid code
  2011-04-04 12:31 [Qemu-devel] [PATCH] Fix build error in usb-ccid code Dmitry Eremin-Solenikov
@ 2011-04-04 12:34 ` Peter Maydell
  2011-04-04 13:15   ` Dmitry Eremin-Solenikov
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2011-04-04 12:34 UTC (permalink / raw)
  To: Dmitry Eremin-Solenikov; +Cc: qemu-devel

On 4 April 2011 13:31, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> wrote:
> W/o this fix I'm getting the following error:
> cc1: warnings being treated as errors
> hw/usb-ccid.c: In function ‘ccid_card_card_error’:
> hw/usb-ccid.c:1202:5: error: format ‘%lX’ expects type ‘long unsigned int’, but argument 2 has type ‘uint64_t’

David Gibson posted a patch for that earlier this morning:
http://patchwork.ozlabs.org/patch/89577/

-- PMM

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] Fix build error in usb-ccid code
  2011-04-04 12:34 ` Peter Maydell
@ 2011-04-04 13:15   ` Dmitry Eremin-Solenikov
  0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Eremin-Solenikov @ 2011-04-04 13:15 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-devel

On 4/4/11, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 4 April 2011 13:31, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> wrote:
>> W/o this fix I'm getting the following error:
>> cc1: warnings being treated as errors
>> hw/usb-ccid.c: In function ‘ccid_card_card_error’:
>> hw/usb-ccid.c:1202:5: error: format ‘%lX’ expects type ‘long unsigned
>> int’, but argument 2 has type ‘uint64_t’
>
> David Gibson posted a patch for that earlier this morning:
> http://patchwork.ozlabs.org/patch/89577/

Sorry for the noise then.

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-04-04 13:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-04 12:31 [Qemu-devel] [PATCH] Fix build error in usb-ccid code Dmitry Eremin-Solenikov
2011-04-04 12:34 ` Peter Maydell
2011-04-04 13:15   ` Dmitry Eremin-Solenikov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).