From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSbPY-0000UL-59 for qemu-devel@nongnu.org; Fri, 03 Jun 2011 16:56:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QSbPW-0004bR-RT for qemu-devel@nongnu.org; Fri, 03 Jun 2011 16:56:03 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:58098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSbPW-0004bI-G3 for qemu-devel@nongnu.org; Fri, 03 Jun 2011 16:56:02 -0400 Received: by fxm2 with SMTP id 2so1729926fxm.4 for ; Fri, 03 Jun 2011 13:56:01 -0700 (PDT) MIME-Version: 1.0 Sender: vapier.adi@gmail.com In-Reply-To: <4DE92399.5070007@iki.fi> References: <1305677682-21158-1-git-send-email-vapier@gentoo.org> <4DE92399.5070007@iki.fi> From: Mike Frysinger Date: Fri, 3 Jun 2011 16:55:41 -0400 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] linux-user: add pselect6 syscall support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: riku voipio Cc: qemu-devel@nongnu.org On Fri, Jun 3, 2011 at 14:10, riku voipio wrote: > On 05/18/2011 03:14 AM, Mike Frysinger wrote: >> Some architectures (like Blackfin) only implement pselect6 (and skip >> select/newselect). =C2=A0So add support for it using existing newselect = code. > > There is a blackfin qemu? i posted it to the list for feedback, but i havent followed up since > Anyways, with this patch pselect01 ltp testcase > starts failing. Looks like (at least on arm), arg6 is set and valid point= er, > but arg7[0] is 0, which quite doesn't work as lock_user read target... > > Checking if arg7=3D=3D0 and setting sig_ptr to null in that case makes th= e > testcase to work, but is that correct? looking at the kernel code, it accepts a 6th arg which contains a NULL pointer (and then just ignores it), so i'll do the same -mike