qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] inconsistency between device traversal in qdev and legacy
Date: Thu, 9 Jun 2011 15:32:27 +0100	[thread overview]
Message-ID: <BANLkTinQKzPNsYAqmnnrva63Z36KHLOESQ@mail.gmail.com> (raw)
In-Reply-To: <m37h8v85r7.fsf@blackfin.pond.sub.org>

On 9 June 2011 14:59, Markus Armbruster <armbru@redhat.com> wrote:
> The fact that we duplicate qtree information in a separate list "busses"
> either means we've been too lazy to garbage collect busses, or we've
> failed to make working with the qtree as easy as it should be.

If you get rid of busses you need to update usb-musb.c to
be more qdev-ish (so it has a parent device it can pass to
usb_bus_new()). Otherwise the USB bus it creates won't appear
anywhere (at the moment it at least appears on the busses list
so it's usable with the legacy syntax if not with -device.)

(There's code in the meego/qemu-linaro trees that does this, but
it's a bit tangled up with the other patches at the moment.)

-- PMM

      parent reply	other threads:[~2011-06-09 14:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 15:07 [Qemu-devel] inconsistency between device traversal in qdev and legacy Peter Maydell
2011-06-08 17:00 ` Gerd Hoffmann
2011-06-08 17:37   ` Andreas Färber
2011-06-08 17:39     ` Peter Maydell
2011-06-08 18:19       ` Rob Landley
2011-06-08 19:06       ` Andreas Färber
2011-06-09 13:59   ` Markus Armbruster
2011-06-09 14:12     ` Gerd Hoffmann
2011-06-09 14:32     ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinQKzPNsYAqmnnrva63Z36KHLOESQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).