[Qemu-devel] [PATCH] Minor spelling mistakes in hw/usb-ccid.c

[Qemu-devel] [PATCH] Minor spelling mistakes in hw/usb-ccid.c

[Brad Hards]

Hi,

While looking at David Gibson's build-fix for hw/usb-ccid.c, I noticed a spello
in a comment on the following (unchanged) line.

This patch fixes that, and a couple of other spellos, in that file.

Brad

 - - 

From e24a4cfce56799e091ce75aafa20c697ec5fe685 Mon Sep 17 00:00:00 2001
From: Brad Hards <bradh@frogmouth.net>
Date: Tue, 5 Apr 2011 07:39:10 +1000
Subject: [PATCH] usb-ccid: spelling fixes.

Signed-off-by: Brad Hards <bradh@frogmouth.net>
---
 hw/usb-ccid.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/usb-ccid.c b/hw/usb-ccid.c
index 44156cc..079b4a2 100644
--- a/hw/usb-ccid.c
+++ b/hw/usb-ccid.c
@@ -22,7 +22,7 @@
  *  "Universal Serial Bus, Device Class: Smart Card"
  *  Specification for Integrated Circuit(s) Cards Interface Devices
  *
- * Endianess note: from the spec (1.3)
+ * Endianness note: from the spec (1.3)
  *  "Fields that are larger than a byte are stored in little endian"
  *
  * KNOWN BUGS
@@ -172,7 +172,7 @@ enum {
     CLOCK_STATUS_RUNNING = 0,
     /*
      * 0 - Clock Running, 1 - Clock stopped in State L, 2 - H,
-     * 3 - unkonwn state. rest are RFU
+     * 3 - unknown state. rest are RFU
      */
 };
 
@@ -1200,7 +1200,7 @@ void ccid_card_card_error(CCIDCardState *card, uint64_t error)
     s->bmCommandStatus = COMMAND_STATUS_FAILED;
     s->last_answer_error = error;
     DPRINTF(s, 1, "VSC_Error: %" PRIX64 "\n", s->last_answer_error);
-    /* TODO: these error's should be more verbose and propogated to the guest.*/
+    /* TODO: these errors should be more verbose and propagated to the guest.*/
     /*
      * We flush all pending answers on CardRemove message in ccid-card-passthru,
      * so check that first to not trigger abort
@@ -1319,7 +1319,7 @@ static void ccid_pre_save(void *opaque)
     if (s->dev.attached) {
         /*
          * Migrating an open device, ignore reconnection CHR_EVENT to avoid an
-         * erronous detach.
+         * erroneous detach.
          */
         s->migration_state = MIGRATION_MIGRATED;
     }
-- 
1.7.1

Re: [Qemu-devel] [PATCH] Minor spelling mistakes in hw/usb-ccid.c

[Alon Levy]

On Tue, Apr 05, 2011 at 07:54:04AM +1000, Brad Hards wrote:
> Hi,
> 
> While looking at David Gibson's build-fix for hw/usb-ccid.c, I noticed a spello
> in a comment on the following (unchanged) line.
> 
> This patch fixes that, and a couple of other spellos, in that file.

ACK. Thanks.

> 
> Brad
> 
>  - - 
> 
> From e24a4cfce56799e091ce75aafa20c697ec5fe685 Mon Sep 17 00:00:00 2001
> From: Brad Hards <bradh@frogmouth.net>
> Date: Tue, 5 Apr 2011 07:39:10 +1000
> Subject: [PATCH] usb-ccid: spelling fixes.
> 
> Signed-off-by: Brad Hards <bradh@frogmouth.net>
> ---
>  hw/usb-ccid.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/usb-ccid.c b/hw/usb-ccid.c
> index 44156cc..079b4a2 100644
> --- a/hw/usb-ccid.c
> +++ b/hw/usb-ccid.c
> @@ -22,7 +22,7 @@
>   *  "Universal Serial Bus, Device Class: Smart Card"
>   *  Specification for Integrated Circuit(s) Cards Interface Devices
>   *
> - * Endianess note: from the spec (1.3)
> + * Endianness note: from the spec (1.3)
>   *  "Fields that are larger than a byte are stored in little endian"
>   *
>   * KNOWN BUGS
> @@ -172,7 +172,7 @@ enum {
>      CLOCK_STATUS_RUNNING = 0,
>      /*
>       * 0 - Clock Running, 1 - Clock stopped in State L, 2 - H,
> -     * 3 - unkonwn state. rest are RFU
> +     * 3 - unknown state. rest are RFU
>       */
>  };
>  
> @@ -1200,7 +1200,7 @@ void ccid_card_card_error(CCIDCardState *card, uint64_t error)
>      s->bmCommandStatus = COMMAND_STATUS_FAILED;
>      s->last_answer_error = error;
>      DPRINTF(s, 1, "VSC_Error: %" PRIX64 "\n", s->last_answer_error);
> -    /* TODO: these error's should be more verbose and propogated to the guest.*/
> +    /* TODO: these errors should be more verbose and propagated to the guest.*/
>      /*
>       * We flush all pending answers on CardRemove message in ccid-card-passthru,
>       * so check that first to not trigger abort
> @@ -1319,7 +1319,7 @@ static void ccid_pre_save(void *opaque)
>      if (s->dev.attached) {
>          /*
>           * Migrating an open device, ignore reconnection CHR_EVENT to avoid an
> -         * erronous detach.
> +         * erroneous detach.
>           */
>          s->migration_state = MIGRATION_MIGRATED;
>      }
> -- 
> 1.7.1
> 
> 

Re: [Qemu-devel] [PATCH] Minor spelling mistakes in hw/usb-ccid.c

[Stefan Hajnoczi]

On Wed, Apr 6, 2011 at 9:15 AM, Alon Levy <alevy@redhat.com> wrote:
> On Tue, Apr 05, 2011 at 07:54:04AM +1000, Brad Hards wrote:
>> Hi,
>>
>> While looking at David Gibson's build-fix for hw/usb-ccid.c, I noticed a spello
>> in a comment on the following (unchanged) line.
>>
>> This patch fixes that, and a couple of other spellos, in that file.
>
> ACK. Thanks.

Merged into my trivial-patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches

I will send a pull request so this can be merged into qemu.git.

The trivial patches tree is a new thing that was proposed recently so
here's the background.  The idea is to collect small patches that are
easy to review and apply.  A single pull request is then sent which a
qemu.git maintainer will apply.  This should prevent patches slipping
through the cracks and lingering on the mailing list.

The trivial patches team was announced in yesterdays community call minutes:
http://www.mail-archive.com/kvm@vger.kernel.org/msg51601.html

If you want to know more:
http://wiki.qemu.org/Contribute/TrivialPatches

Stefan