From: Blue Swirl <blauwirbel@gmail.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: armbru@redhat.com, aliguori@us.ibm.com,
Lai Jiangshan <laijs@cn.fujitsu.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/5] QMP: add inject-nmi qmp command
Date: Mon, 13 Jun 2011 00:22:36 +0300 [thread overview]
Message-ID: <BANLkTinTsg_sRDj1WWc3zdRnxB=akbZvWQ@mail.gmail.com> (raw)
In-Reply-To: <20110606111725.663edcb1@doriath>
On Mon, Jun 6, 2011 at 5:17 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> On Sat, 4 Jun 2011 11:34:17 +0300
> Blue Swirl <blauwirbel@gmail.com> wrote:
>
>> On Wed, Jun 1, 2011 at 6:54 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
>> > From: Lai Jiangshan <laijs@cn.fujitsu.com>
>> >
>> > inject-nmi command injects an NMI on all CPUs of guest.
>> > It is only supported for x86 guest currently, it will
>> > returns "Unsupported" error for non-x86 guest.
>>
>> Please rename the command to 'x-inject-nmi' to point out that it will
>> be replaced by a generic method later.
>
> Won't the generic interface be called 'inject'? In that case calling this
> command 'inject-nmi' makes sense as it's exactly what the command does and
> in the future it can be written in terms of the new 'inject' command.
This is a bit useless since the patch was committed, but I was pointed
out that 'inject' wasn't so great name, 'raise/lower/pulse' should
have been more precise. But I guess we can live with yet another poor
interface, so who cares what the name is.
next prev parent reply other threads:[~2011-06-12 21:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 15:54 [Qemu-devel] [PULL 0/5]: Monitor queue Luiz Capitulino
2011-06-01 15:54 ` [Qemu-devel] [PATCH 1/5] QMP: QError: New QERR_UNSUPPORTED Luiz Capitulino
2011-06-01 15:54 ` [Qemu-devel] [PATCH 2/5] QMP: add inject-nmi qmp command Luiz Capitulino
2011-06-04 8:34 ` Blue Swirl
2011-06-06 14:17 ` Luiz Capitulino
2011-06-12 21:22 ` Blue Swirl [this message]
2011-06-01 15:54 ` [Qemu-devel] [PATCH 3/5] HMP: Use QMP inject nmi implementation Luiz Capitulino
2011-06-01 15:54 ` [Qemu-devel] [PATCH 4/5] QMP: add get_events(wait=True) option Luiz Capitulino
2011-06-01 15:54 ` [Qemu-devel] [PATCH 5/5] QMP: add server mode to QEMUMonitorProtocol Luiz Capitulino
2011-06-02 2:19 ` Brad Hards
2011-06-02 9:02 ` Daniel P. Berrange
2011-06-09 12:40 ` [Qemu-devel] [PULL 0/5]: Monitor queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinTsg_sRDj1WWc3zdRnxB=akbZvWQ@mail.gmail.com' \
--to=blauwirbel@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).