From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60837)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QVs7W-0001TQ-R7
	for qemu-devel@nongnu.org; Sun, 12 Jun 2011 17:22:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QVs7V-0004DE-3A
	for qemu-devel@nongnu.org; Sun, 12 Jun 2011 17:22:58 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:55624)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1QVs7U-0004D8-Rr
	for qemu-devel@nongnu.org; Sun, 12 Jun 2011 17:22:56 -0400
Received: by qyk10 with SMTP id 10so2585837qyk.4
	for <qemu-devel@nongnu.org>; Sun, 12 Jun 2011 14:22:56 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20110606111725.663edcb1@doriath>
References: <1306943645-20313-1-git-send-email-lcapitulino@redhat.com>
	<1306943645-20313-3-git-send-email-lcapitulino@redhat.com>
	<BANLkTi=pVLzNSJ4k+Se_KGV8pJ=KBiDfFQ@mail.gmail.com>
	<20110606111725.663edcb1@doriath>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 13 Jun 2011 00:22:36 +0300
Message-ID: <BANLkTinTsg_sRDj1WWc3zdRnxB=akbZvWQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 2/5] QMP: add inject-nmi qmp command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: armbru@redhat.com, aliguori@us.ibm.com, Lai Jiangshan <laijs@cn.fujitsu.com>, qemu-devel@nongnu.org

On Mon, Jun 6, 2011 at 5:17 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> On Sat, 4 Jun 2011 11:34:17 +0300
> Blue Swirl <blauwirbel@gmail.com> wrote:
>
>> On Wed, Jun 1, 2011 at 6:54 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
>> > From: Lai Jiangshan <laijs@cn.fujitsu.com>
>> >
>> > inject-nmi command injects an NMI on all CPUs of guest.
>> > It is only supported for x86 guest currently, it will
>> > returns "Unsupported" error for non-x86 guest.
>>
>> Please rename the command to 'x-inject-nmi' to point out that it will
>> be replaced by a generic method later.
>
> Won't the generic interface be called 'inject'? In that case calling this
> command 'inject-nmi' makes sense as it's exactly what the command does and
> in the future it can be written in terms of the new 'inject' command.

This is a bit useless since the patch was committed, but I was pointed
out that 'inject' wasn't so great name, 'raise/lower/pulse' should
have been more precise. But I guess we can live with yet another poor
interface, so who cares what the name is.