From: Stefan Hajnoczi <stefanha@gmail.com>
To: Dmitry Konishchev <konishchev@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
stanislav.ievlev@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization
Date: Wed, 18 May 2011 08:57:11 +0100 [thread overview]
Message-ID: <BANLkTinbceD4PVaHabCzYxyT7EtFnTNKtg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikodwB2aNsPL42DCk=dq43pg+kKQw@mail.gmail.com>
On Wed, May 18, 2011 at 7:55 AM, Dmitry Konishchev <konishchev@gmail.com> wrote:
> So, if you are agreed with the said above, you can accept this patch
> and then I'll write an enchancement for it with bdrv_is_allocated()
> because it is going to include this patch.
Yes, optimizing is_not_zero() is good. The only additional thing I
suggest is adding a comment before the function to document the length
constraint.
Kevin Wolf is CCed, he's the QEMU block layer maintainer and may have
additional thoughts before accepting this patch.
Stefan
next prev parent reply other threads:[~2011-05-18 7:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 14:33 [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization Dmitry Konishchev
2011-05-17 15:35 ` Stefan Hajnoczi
2011-05-18 6:55 ` Dmitry Konishchev
2011-05-18 7:57 ` Stefan Hajnoczi [this message]
2011-05-18 8:05 ` Kevin Wolf
2011-05-18 9:18 ` Dmitry Konishchev
2011-05-18 9:31 ` Kevin Wolf
2011-05-18 10:27 ` Dmitry Konishchev
2011-05-18 11:03 ` [Qemu-devel] [PATCH] is_not_zero() optimization in qemu-img Dmitry Konishchev
2011-05-18 12:14 ` Kevin Wolf
2011-05-18 9:40 ` [Qemu-devel] [PATCH] [qemu-img] CPU consuming optimization Peter Maydell
2011-05-18 9:40 ` Peter Maydell
2011-05-18 10:27 ` Dmitry Konishchev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinbceD4PVaHabCzYxyT7EtFnTNKtg@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=konishchev@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stanislav.ievlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).