From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49767)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QVogD-0004SP-JD
	for qemu-devel@nongnu.org; Sun, 12 Jun 2011 13:42:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QVogC-0007KP-4S
	for qemu-devel@nongnu.org; Sun, 12 Jun 2011 13:42:33 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:44341)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QVogB-0007K2-VX
	for qemu-devel@nongnu.org; Sun, 12 Jun 2011 13:42:32 -0400
Received: by pwi6 with SMTP id 6so1913064pwi.4
	for <qemu-devel@nongnu.org>; Sun, 12 Jun 2011 10:42:30 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4DF32FC6.3040607@web.de>
References: <4DF32FC6.3040607@web.de>
Date: Sun, 12 Jun 2011 18:42:30 +0100
Message-ID: <BANLkTinbeXYnDXoTueY9G4gSzF7LB8i8Nw@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Reset system before loadvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On 11 June 2011 10:05, Jan Kiszka <jan.kiszka@web.de> wrote:
> @@ -2074,6 +2074,7 @@ int load_vmstate(const char *name)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EINVAL;
> =C2=A0 =C2=A0 }
>
> + =C2=A0 =C2=A0qemu_system_reset();
> =C2=A0 =C2=A0 ret =3D qemu_loadvm_state(f);

This means that if we're doing a load because the user
passed -loadvm on the command line we'll end up doing
qemu_system_reset() twice (once in vl.c and then again
here). Does that matter?

-- PMM