From: Blue Swirl <blauwirbel@gmail.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] w32: Fix compilation of new code
Date: Sun, 3 Apr 2011 12:10:59 +0300 [thread overview]
Message-ID: <BANLkTincWPdM2kqdjKevSXnVP1EXACKAjw@mail.gmail.com> (raw)
In-Reply-To: <1301605129-12808-1-git-send-email-weil@mail.berlios.de>
On Thu, Mar 31, 2011 at 11:58 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Some recently added new code did not compile for w32 targets.
>
> The functions qemu_iohandler_fill and qemu_iohandler_poll need
> data type fd_set which is declared in winsock2.h for w32 targets.
>
> Moving the functions from qemu-common.h to qemu_socket.h fixes
> compilations for w32 without adding a new include file to qemu-common.h.
There's nothing socket specific in qemu_iohandler_fill and
qemu_iohandler_poll, so I'd rather fix qemu-common.h. But I have a
patch in my working queue to move OS specific stuff to qemu-common.h,
I'll fix this there.
next prev parent reply other threads:[~2011-04-03 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 20:58 [Qemu-devel] [PATCH] w32: Fix compilation of new code Stefan Weil
2011-04-01 7:04 ` [Qemu-devel] " Paolo Bonzini
2011-04-03 9:10 ` Blue Swirl [this message]
2011-04-03 9:41 ` Stefan Weil
2011-04-03 10:05 ` Blue Swirl
2011-04-08 19:49 ` Stefan Weil
2011-04-08 20:18 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTincWPdM2kqdjKevSXnVP1EXACKAjw@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).