From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36185 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6JLD-0004AM-7R
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 05:11:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Q6JL7-00015W-Rn
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 05:11:26 -0400
Received: from mail-vx0-f173.google.com ([209.85.220.173]:46341)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Q6JL7-00015D-Mn
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 05:11:21 -0400
Received: by vxb41 with SMTP id 41so4106425vxb.4
	for <qemu-devel@nongnu.org>; Sun, 03 Apr 2011 02:11:20 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1301605129-12808-1-git-send-email-weil@mail.berlios.de>
References: <1301605129-12808-1-git-send-email-weil@mail.berlios.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 3 Apr 2011 12:10:59 +0300
Message-ID: <BANLkTincWPdM2kqdjKevSXnVP1EXACKAjw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Re: [PATCH] w32: Fix compilation of new code
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>

On Thu, Mar 31, 2011 at 11:58 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Some recently added new code did not compile for w32 targets.
>
> The functions qemu_iohandler_fill and qemu_iohandler_poll need
> data type fd_set which is declared in winsock2.h for w32 targets.
>
> Moving the functions from qemu-common.h to qemu_socket.h fixes
> compilations for w32 without adding a new include file to qemu-common.h.

There's nothing socket specific in qemu_iohandler_fill and
qemu_iohandler_poll, so I'd rather fix qemu-common.h. But I have a
patch in my working queue to move OS specific stuff to qemu-common.h,
I'll fix this there.