qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Mark McLoughlin <markmc@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] net: add drop_packets parameter to -net nic
Date: Tue, 26 Apr 2011 17:07:40 +0700	[thread overview]
Message-ID: <BANLkTinccCPHh+oj-dq25yKgz99JSiDyyg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTin4vGrGEkw6MmWXtn-pfXP3fk=zQA@mail.gmail.com>

On Tue, Apr 26, 2011 at 4:14 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> The behavior you are describing sounds like a bug in QEMU's network
> layer.  If RX is disabled we should not queue incoming packets.
>
> Have you looked into fixing QEMU so that the queue is disabled when RX
> is disabled?

it's in e1000_can_receive(): it can receive if rx is enabled
(E1000_RCTL_EN) and has enough buffer, which means if the driver
disables rx, packets queue up. Isn't that correct behavior? Sorry I'm
new in this area.
-- 
Duy

      reply	other threads:[~2011-04-26 10:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-25  2:10 [Qemu-devel] [PATCH] net: add drop_packets parameter to -net nic Nguyễn Thái Ngọc Duy
2011-04-25 13:40 ` Stefan Hajnoczi
2011-04-25 13:42   ` Anthony Liguori
2011-04-25 14:06   ` Nguyen Thai Ngoc Duy
2011-04-26  9:14     ` Stefan Hajnoczi
2011-04-26 10:07       ` Nguyen Thai Ngoc Duy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinccCPHh+oj-dq25yKgz99JSiDyyg@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).