From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QABa2-0002CK-QW for qemu-devel@nongnu.org; Wed, 13 Apr 2011 21:42:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QABa1-0003P2-Tc for qemu-devel@nongnu.org; Wed, 13 Apr 2011 21:42:46 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:47398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QABa1-0003Oy-Qj for qemu-devel@nongnu.org; Wed, 13 Apr 2011 21:42:45 -0400 Received: by iym10 with SMTP id 10so1307453iym.4 for ; Wed, 13 Apr 2011 18:42:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1301744191-16255-1-git-send-email-weil@mail.berlios.de> References: <1301744191-16255-1-git-send-email-weil@mail.berlios.de> Date: Thu, 14 Apr 2011 09:42:44 +0800 Message-ID: From: TeLeMan Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] Fix conversions from pointer to tcg_target_long List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Blue Swirl , QEMU Developers On Sat, Apr 2, 2011 at 19:36, Stefan Weil wrote: > tcg_gen_exit_tb takes a parameter of type tcg_target_long, > so the type casts of pointer to long should be replaced by > type casts of pointer to tcg_target_long (suggested by Blue Swirl). > > These changes are needed for build environments where > sizeof(long) != sizeof(void *), especially for w64. There are many "(long)tb" in exec.c and the types of tb_next in TranslationBlock, tc_ptr in tb_find_pc(), searched_pc etc. are "unsigned long". So more patches for w64 are needed.