From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9p70-0007qx-7o for qemu-devel@nongnu.org; Tue, 12 Apr 2011 21:43:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9mHO-0004Z5-1i for qemu-devel@nongnu.org; Tue, 12 Apr 2011 18:41:50 -0400 Received: from mail-vx0-f173.google.com ([209.85.220.173]:55772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9mHN-0004Z0-T2 for qemu-devel@nongnu.org; Tue, 12 Apr 2011 18:41:50 -0400 Received: by vxb41 with SMTP id 41so43265vxb.4 for ; Tue, 12 Apr 2011 15:41:49 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1302645571-20500-16-git-send-email-aurelien@aurel32.net> References: <1302645571-20500-1-git-send-email-aurelien@aurel32.net> <1302645571-20500-16-git-send-email-aurelien@aurel32.net> Date: Tue, 12 Apr 2011 23:41:49 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 15/19] target-arm: fix wrong usage of floatx80_eq_quiet() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 12 April 2011 22:59, Aurelien Jarno wrote: > I haven't look at the documentation, but for the neighbouring code it looks > clear that floatx80_eq() should be used instead of floatx80_eq_quiet(). Actually I think it's irrelevant -- PerformComparisonOperation() is called only once, and the code before it carefully checks for any NaNs and takes a different code path in that case (jumping to the 'unordered' label). So it doesn't matter which function we use here. I don't particularly object if you think using the non _quiet one is aesthetically tidier. (The nwfpe code is all hovering on the edge of total obsolescence anyhow; I certainly don't have any test cases for it.) -- PMM