From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Justin M. Forbes" <jforbes@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qed: Fix consistency check on 32-bit hosts
Date: Tue, 26 Apr 2011 10:48:22 +0100 [thread overview]
Message-ID: <BANLkTini9RhdUx=Kc-tPyMVaeVMoDhJ_vA@mail.gmail.com> (raw)
In-Reply-To: <4DB685F7.7020603@redhat.com>
On Tue, Apr 26, 2011 at 9:44 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 24.04.2011 19:38, schrieb Stefan Hajnoczi:
>> The qed_bytes_to_clusters() function is normally used with size_t
>> lengths. Consistency check used it with file size length and therefore
>> failed on 32-bit hosts when the image file is 4 GB or more.
>>
>> Make qed_bytes_to_clusters() explicitly 64-bit and update consistency
>> check to keep 64-bit cluster counts.
>>
>> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
>> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>
> Thanks, applied to the block branch.
Please apply to stable. This fixes a segfault when checking an image
on 32-bit hosts.
Stefan
prev parent reply other threads:[~2011-04-26 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-24 17:38 [Qemu-devel] [PATCH] qed: Fix consistency check on 32-bit hosts Stefan Hajnoczi
2011-04-26 8:44 ` Kevin Wolf
2011-04-26 9:48 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTini9RhdUx=Kc-tPyMVaeVMoDhJ_vA@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=Qemu-devel@nongnu.org \
--cc=jforbes@redhat.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).