From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39381)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QEesa-0003Dq-JD
	for Qemu-devel@nongnu.org; Tue, 26 Apr 2011 05:48:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QEesZ-0004Az-GP
	for Qemu-devel@nongnu.org; Tue, 26 Apr 2011 05:48:24 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:57559)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QEesZ-0004Av-DH
	for Qemu-devel@nongnu.org; Tue, 26 Apr 2011 05:48:23 -0400
Received: by ywl41 with SMTP id 41so208718ywl.4
	for <Qemu-devel@nongnu.org>; Tue, 26 Apr 2011 02:48:22 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4DB685F7.7020603@redhat.com>
References: <1303666738-26558-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<4DB685F7.7020603@redhat.com>
Date: Tue, 26 Apr 2011 10:48:22 +0100
Message-ID: <BANLkTini9RhdUx=Kc-tPyMVaeVMoDhJ_vA@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qed: Fix consistency check on 32-bit hosts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Justin M. Forbes" <jforbes@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Qemu-devel@nongnu.org

On Tue, Apr 26, 2011 at 9:44 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 24.04.2011 19:38, schrieb Stefan Hajnoczi:
>> The qed_bytes_to_clusters() function is normally used with size_t
>> lengths. =A0Consistency check used it with file size length and therefor=
e
>> failed on 32-bit hosts when the image file is 4 GB or more.
>>
>> Make qed_bytes_to_clusters() explicitly 64-bit and update consistency
>> check to keep 64-bit cluster counts.
>>
>> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
>> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>
> Thanks, applied to the block branch.

Please apply to stable.  This fixes a segfault when checking an image
on 32-bit hosts.

Stefan