From: Peter Maydell <peter.maydell@linaro.org>
To: Laurent Vivier <Laurent@vivier.eu>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU
Date: Wed, 6 Apr 2011 10:07:43 +0100 [thread overview]
Message-ID: <BANLkTinjacKFYJXvyBE+TptjHrZGK1XEqw@mail.gmail.com> (raw)
In-Reply-To: <1302041726.15215.10.camel@Quad>
On 5 April 2011 23:15, Laurent Vivier <Laurent@vivier.eu> wrote:
> Le mardi 05 avril 2011 à 22:54 +0100, Peter Maydell a écrit :
>> On 5 April 2011 22:48, Laurent Vivier <Laurent@vivier.eu> wrote:
>> > Le lundi 04 avril 2011 à 12:09 +0100, Peter Maydell a écrit :
>> >> -#if defined(TARGET_SPARC) || defined(TARGET_S390X)
>> >> +#if defined(CONFIG_SOFTFLOAT)
>> >
>> > Why don't you use "#if defined(FLOAT128)" ?
>>
>> I did consider that, but I felt FLOAT128 was a softfloat-internal
>> macro rather than part of the API softfloat provides to the rest
>> of qemu.
>
> But, for instance, "#ifdef FLOATX80" is used in target-i386/cpu.h and
> target-i386/op_helper.c.
Those uses seem conceptually wrong to me: either a target needs
80 bit floats, or it doesn't. It shouldn't behave differently
depending on what host it was compiled on. However this is really
just legacy of the fact that target-i386 is still compiled with
softfloat-native rather than proper softfloat.
Personally I would also delete the FLOAT128 ifdefs in target-ppc
since we always compile with softfloat now.
However I don't feel very strongly about any of this; mostly I
just wanted to get rid of the target and host specific ifdeffery.
-- PMM
prev parent reply other threads:[~2011-04-06 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 11:09 [Qemu-devel] [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU Peter Maydell
2011-04-04 14:47 ` [Qemu-devel] " Alexander Graf
2011-04-04 15:41 ` Peter Maydell
2011-04-04 20:50 ` [Qemu-devel] " Aurelien Jarno
2011-04-05 21:48 ` Laurent Vivier
2011-04-05 21:54 ` Peter Maydell
2011-04-05 22:15 ` Laurent Vivier
2011-04-06 9:07 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinjacKFYJXvyBE+TptjHrZGK1XEqw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=Laurent@vivier.eu \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).