From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33172 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7OiI-000402-PQ for qemu-devel@nongnu.org; Wed, 06 Apr 2011 05:07:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7OiH-0007SN-40 for qemu-devel@nongnu.org; Wed, 06 Apr 2011 05:07:46 -0400 Received: from mail-vx0-f173.google.com ([209.85.220.173]:40667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7OiH-0007Ry-1b for qemu-devel@nongnu.org; Wed, 06 Apr 2011 05:07:45 -0400 Received: by vxb41 with SMTP id 41so1045095vxb.4 for ; Wed, 06 Apr 2011 02:07:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1302041726.15215.10.camel@Quad> References: <1301915362-2626-1-git-send-email-peter.maydell@linaro.org> <1302040124.15215.5.camel@Quad> <1302041726.15215.10.camel@Quad> Date: Wed, 6 Apr 2011 10:07:43 +0100 Message-ID: Subject: Re: [Qemu-devel] [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-devel@nongnu.org, Aurelien Jarno , Alexander Graf On 5 April 2011 23:15, Laurent Vivier wrote: > Le mardi 05 avril 2011 =C3=A0 22:54 +0100, Peter Maydell a =C3=A9crit : >> On 5 April 2011 22:48, Laurent Vivier wrote: >> > Le lundi 04 avril 2011 =C3=A0 12:09 +0100, Peter Maydell a =C3=A9crit = : >> >> -#if defined(TARGET_SPARC) || defined(TARGET_S390X) >> >> +#if defined(CONFIG_SOFTFLOAT) >> > >> > Why don't you use "#if defined(FLOAT128)" ? >> >> I did consider that, but I felt FLOAT128 was a softfloat-internal >> macro rather than part of the API softfloat provides to the rest >> of qemu. > > But, for instance, "#ifdef FLOATX80" is used in target-i386/cpu.h and > target-i386/op_helper.c. Those uses seem conceptually wrong to me: either a target needs 80 bit floats, or it doesn't. It shouldn't behave differently depending on what host it was compiled on. However this is really just legacy of the fact that target-i386 is still compiled with softfloat-native rather than proper softfloat. Personally I would also delete the FLOAT128 ifdefs in target-ppc since we always compile with softfloat now. However I don't feel very strongly about any of this; mostly I just wanted to get rid of the target and host specific ifdeffery. -- PMM