From: Mike Frysinger <vapier@gentoo.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ignore patch related files
Date: Tue, 17 May 2011 20:14:25 -0400 [thread overview]
Message-ID: <BANLkTinn3_yNU_aGiB4J5VGf8mOsnzr=zw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimoiE_s3C+7rNf_d-oQMZ5D42E0YQ@mail.gmail.com>
On Tue, May 17, 2011 at 18:17, Peter Maydell wrote:
> On 17 May 2011 22:10, Mike Frysinger wrote:
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -58,6 +58,10 @@ QMP/qmp-commands.txt
>> *.orig
>> .pc
>> patches
>> +*.diff
>> +*.patch
>> +*.rej
>> +*.orig
>> pc-bios/bios-pq/status
>> pc-bios/vgabios-pq/status
>> pc-bios/optionrom/linuxboot.bin
>
> Er, *.orig is already in .gitignore, you can see it in
> the context here...
yes, this patch was written before that .orig entry
> Also I tend to agree with the argument made by Stefan Weil
> in the final comment on this patch:
> http://patchwork.ozlabs.org/patch/84320/
> qemu's .gitignore should contain only entries specific to qemu
> (files created by running makefile targets and the like);
> generic things like .diff/.patch/.rej should be in your
> local git config instead.
using that logic, quite a few entries shouldn't be in .gitignore.
like the "*.orig" you already quoted. and the patch you refer to was
merged.
-mike
next prev parent reply other threads:[~2011-05-18 0:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 21:10 [Qemu-devel] [PATCH] ignore patch related files Mike Frysinger
2011-05-17 22:17 ` Peter Maydell
2011-05-18 0:14 ` Mike Frysinger [this message]
2011-05-18 0:18 ` [Qemu-devel] [PATCH v2] " Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2010-03-29 6:09 [Qemu-devel] [PATCH] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinn3_yNU_aGiB4J5VGf8mOsnzr=zw@mail.gmail.com' \
--to=vapier@gentoo.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).