From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA26q-0006H8-Sd for qemu-devel@nongnu.org; Wed, 13 Apr 2011 11:36:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QA26k-0001V4-SB for qemu-devel@nongnu.org; Wed, 13 Apr 2011 11:36:00 -0400 Received: from smtp-out.google.com ([216.239.44.51]:14437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA26k-0001Us-AS for qemu-devel@nongnu.org; Wed, 13 Apr 2011 11:35:54 -0400 Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out.google.com with ESMTP id p3DFZrLo012819 for ; Wed, 13 Apr 2011 08:35:53 -0700 Received: from pzk5 (pzk5.prod.google.com [10.243.19.133]) by wpaz29.hot.corp.google.com with ESMTP id p3DFZpG9000315 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Wed, 13 Apr 2011 08:35:52 -0700 Received: by pzk5 with SMTP id 5so313692pzk.36 for ; Wed, 13 Apr 2011 08:35:51 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4DA47FEB.5070402@siemens.com> References: <4DA47FEB.5070402@siemens.com> Date: Wed, 13 Apr 2011 08:35:51 -0700 Message-ID: From: Daisuke Nojiri Content-Type: multipart/alternative; boundary=001636ed6a19469cf204a0ce90f0 Subject: Re: [Qemu-devel] [PATCH] Slirp reverse UDP firewall List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org --001636ed6a19469cf204a0ce90f0 Content-Type: text/plain; charset=ISO-8859-1 Thanks, Jan. I split my patch into three and started a new thread. I also put all options in -net user. Yes, TCP firewall is coming. You'll see some of the added functions will be shared. Dai On Tue, Apr 12, 2011 at 9:38 AM, Jan Kiszka wrote: > On 2011-04-12 18:19, Daisuke Nojiri wrote: > > This patch adds: -drop-udp, -allow-udp ADDR:PORT, -drop-log FILE > > > > e.g.) $ qemu -net user -drop-log qemu.drop -drop-udp -allow-udp > > 10.0.2.3:53 > > No more stand-alone slirp arguments please. That syntax breaks when > instantiating >1 back-ends. > > > > > -drop-udp enables usermode firewall for out-going UDP packats from a > guest. > > All UDP packets except ones allowed by -allow-udp will be dropped. > Dropped > > packets are logged in the file specified by FILE. PORT can be a single > > number > > (e.g. 53) or a range (e.g. [80-81]). If ADDR is ommitted, all addresses > > match > > the rule. > > Will we see a TCP firewall as well? Can we prepare for a more generic > infrastructure, or what makes UDP special? > > Also, please break up in smaller bits (example: logging would be a > separate topic). And make sure that your patches aren't line-wrapped. > > Thanks, > Jan > > -- > Siemens AG, Corporate Technology, CT T DE IT 1 > Corporate Competence Center Embedded Linux > --001636ed6a19469cf204a0ce90f0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thanks, Jan. I split my patch into three and started a new thread. I also p= ut all options in -net user. Yes, TCP firewall is coming. You'll see so= me of the added functions will be shared.

Dai

On Tue, Apr 12, 2011 at 9:38 AM, Jan Kiszka <jan.kiszka@siem= ens.com> wrote:
On 2011-04-12 18:19, Daisuke Nojiri wrote:
> This patch adds: -drop-udp, -allow-udp ADDR:PORT, -drop-log FILE
>
> =A0 e.g.) $ qemu -net user -drop-log qemu.drop -drop-udp -allow-udp > 10.0.2.3:53

No more stand-alone slirp arguments please. That syntax breaks when instantiating >1 back-ends.

>
> -drop-udp enables usermode firewall for out-going UDP packats from a g= uest.
> All UDP packets except ones allowed by -allow-udp will be dropped. Dro= pped
> packets are logged in the file specified by FILE. PORT can be a single=
> number
> (e.g. 53) or a range (e.g. [80-81]). If ADDR is ommitted, all addresse= s
> match
> the rule.

Will we see a TCP firewall as well? Can we prepare for a more generic=
infrastructure, or what makes UDP special?

Also, please break up in smaller bits (example: logging would be a
separate topic). And make sure that your patches aren't line-wrapped.
Thanks,
Jan

--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

--001636ed6a19469cf204a0ce90f0--