From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60916)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QKqPa-0007i1-HX
	for qemu-devel@nongnu.org; Fri, 13 May 2011 07:20:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QKqPY-0006Bk-OT
	for qemu-devel@nongnu.org; Fri, 13 May 2011 07:20:02 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:41858)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QKqPY-0006BW-M4
	for qemu-devel@nongnu.org; Fri, 13 May 2011 07:20:00 -0400
Received: by gwb19 with SMTP id 19so987822gwb.4
	for <qemu-devel@nongnu.org>; Fri, 13 May 2011 04:19:59 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4DCD08AA.7060205@redhat.com>
References: <1305278792-20933-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1305278792-20933-2-git-send-email-stefanha@linux.vnet.ibm.com>
	<4DCD08AA.7060205@redhat.com>
Date: Fri, 13 May 2011 12:19:59 +0100
Message-ID: <BANLkTinvFxs5iB_p7JWCNRuV8bHPZBD=pQ@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 1/4] coroutine: introduce coroutines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Fri, May 13, 2011 at 11:32 AM, Paolo Bonzini <pbonzini@redhat.com> wrote=
:
> On 05/13/2011 11:26 AM, Stefan Hajnoczi wrote:
>>
>> This coroutines implementation is based on the gtk-vnc implementation
>> written by Anthony Liguori<anthony@codemonkey.ws> =A0but it has been
>> significantly rewritten by Kevin Wolf<kwolf@redhat.com> =A0to use
>> setjmp()/longjmp() instead of the more expensive swapcontext().
>
> Since in the future we'll have at least three implementations of coroutin=
es
> (ucontext, win32 fibers, threads) can you squash in something like the
> attached to allow "subclassing" of coroutines using DO_UPCAST)? =A0Resolv=
ing
> conflicts with 4/4 should be trivial

Yes, I'll tweak your patch and add it.

Stefan