From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57633)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QCAFl-00009R-Op
	for qemu-devel@nongnu.org; Tue, 19 Apr 2011 08:42:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QCAFl-0000hT-0J
	for qemu-devel@nongnu.org; Tue, 19 Apr 2011 08:42:01 -0400
Received: from mail-vx0-f173.google.com ([209.85.220.173]:34249)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QCAFk-0000hN-UK
	for qemu-devel@nongnu.org; Tue, 19 Apr 2011 08:42:00 -0400
Received: by vxb41 with SMTP id 41so5009696vxb.4
	for <qemu-devel@nongnu.org>; Tue, 19 Apr 2011 05:42:00 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1303160412-8107-10-git-send-email-aurelien@aurel32.net>
References: <1303160412-8107-1-git-send-email-aurelien@aurel32.net>
	<1303160412-8107-10-git-send-email-aurelien@aurel32.net>
Date: Tue, 19 Apr 2011 13:42:00 +0100
Message-ID: <BANLkTinwsWhr8mYfvS48s2EqENKF=xaXdw@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 09/20] softfloat-native: add
 float*_is_any_nan() functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 18 April 2011 22:00, Aurelien Jarno <aurelien@aurel32.net> wrote:

> @@ -511,4 +530,11 @@ int floatx80_is_quiet_nan( floatx80 a1 )
> =C2=A0 =C2=A0 return ( ( u.i.high & 0x7FFF ) =3D=3D 0x7FFF ) && (uint64_t=
) ( u.i.low<<1 );
> =C2=A0}
>
> +int floatx80_is_any_nan( floatx80 a1 )
> +{
> + =C2=A0 =C2=A0floatx80u u;
> + =C2=A0 =C2=A0u.f =3D a1;
> + =C2=A0 =C2=A0return ((u.i.high & 0x7FFF) =3D=3D 0x7FFF) && ( u.i.low<<1=
 );
> +}
> +
> =C2=A0#endif

As you can just see from the context, the new function is
actually identical to the existing floatx80_is_quiet_nan(),
but the latter is wrong, not this patch :-)

Nobody seems to use floatx80_is_quiet_nan() so if we're just
going to nuke softfloat-native shortly there's no point fixing
it I guess.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM