From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QO6N2-0001R5-FD for qemu-devel@nongnu.org; Sun, 22 May 2011 06:58:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QO6N1-0002vr-C2 for qemu-devel@nongnu.org; Sun, 22 May 2011 06:58:52 -0400 Received: from mail-qy0-f173.google.com ([209.85.216.173]:59546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QO6N1-0002vk-A1 for qemu-devel@nongnu.org; Sun, 22 May 2011 06:58:51 -0400 Received: by qyk36 with SMTP id 36so437947qyk.4 for ; Sun, 22 May 2011 03:58:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4DD2896D.4040405@twiddle.net> References: <4DD2896D.4040405@twiddle.net> From: Blue Swirl Date: Sun, 22 May 2011 13:58:30 +0300 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 02/11] Delete unused tb_invalidate_page_range List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel On Tue, May 17, 2011 at 5:42 PM, Richard Henderson wrote: > On 05/14/2011 12:37 PM, Blue Swirl wrote: >> tb_invalidate_page_range() was intended to be used to invalidate an area of a TB >> which the guest explicitly flushes from i-cache. However, QEMU detects writes >> to code areas where TBs have been generated, so this has never been useful. >> >> Delete the function, adjust callers. >> >> Signed-off-by: Blue Swirl > > Reviewed-by: Richard Henderson Thanks for the review, applied.