From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QDdj6-0000lx-Lr for qemu-devel@nongnu.org; Sat, 23 Apr 2011 10:22:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QDdj5-0002gg-MQ for qemu-devel@nongnu.org; Sat, 23 Apr 2011 10:22:24 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:58900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QDdj5-0002ga-IX for qemu-devel@nongnu.org; Sat, 23 Apr 2011 10:22:23 -0400 Received: by gyg4 with SMTP id 4so411938gyg.4 for ; Sat, 23 Apr 2011 07:22:23 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110406183431.22854.56191.stgit@ginnungagap.bsc.es> References: <20110406183341.22854.93929.stgit@ginnungagap.bsc.es> <20110406183431.22854.56191.stgit@ginnungagap.bsc.es> Date: Sat, 23 Apr 2011 15:22:12 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 06/11] trace: generalize the "property" concept in the trace-events file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Llu=EDs?= Cc: qemu-devel@nongnu.org, chouteau@adacore.com On Wed, Apr 6, 2011 at 7:34 PM, Llu=EDs wrote: > diff --git a/docs/tracing.txt b/docs/tracing.txt > index 34b0901..a9fd85b 100644 > --- a/docs/tracing.txt > +++ b/docs/tracing.txt > @@ -38,7 +38,7 @@ generate code for the trace events. =A0Trace events are= invoked directly from > =A0source code like this: > > =A0 =A0 #include "trace.h" =A0/* needed for trace event prototype */ > - > + > =A0 =A0 void *qemu_malloc(size_t size) > =A0 =A0 { > =A0 =A0 =A0 =A0 void *ptr; > @@ -98,7 +98,7 @@ portability macros, ensure they are preceded and follow= ed by double quotes: > =A04. Name trace events after their function. =A0If there are multiple tr= ace events > =A0 =A0in one function, append a unique distinguisher at the end of the n= ame. > > -5. Declare trace events with the "disable" keyword. =A0Some trace events= can > +5. Declare trace events with the "disable" property. =A0Some trace event= s can > =A0 =A0produce a lot of output and users are typically only interested in= a subset > =A0 =A0of trace events. =A0Marking trace events disabled by default saves= the user > =A0 =A0from having to manually disable noisy trace events. > @@ -168,7 +168,7 @@ The st_change_trace_event_state() function can be use= d to enable or disable trac > =A0events at runtime inside QEMU: > > =A0 =A0 #include "trace.h" > - > + > =A0 =A0 st_change_trace_event_state("virtio_irq", true); /* enable */ > =A0 =A0 [...] > =A0 =A0 st_change_trace_event_state("virtio_irq", false); /* disable */ Tailing whitespace is there due to wiki formatting. Please do not remove i= t. The rest looks good. Stefan