From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>,
qemu-devel@nongnu.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2] vl.c: Replace -virtfs string manipulation with QemuOpts
Date: Tue, 26 Apr 2011 14:37:32 +0100 [thread overview]
Message-ID: <BANLkTinzJdrbStS6VP38e8Ff4XMT+44p=Q@mail.gmail.com> (raw)
In-Reply-To: <1300264303-10092-1-git-send-email-stefanha@linux.vnet.ibm.com>
On Wed, Mar 16, 2011 at 8:31 AM, Stefan Hajnoczi
<stefanha@linux.vnet.ibm.com> wrote:
> The -virtfs option creates an fsdev representing the pass-through file
> system and a guest-visible virtio-9p-pci device that can access this
> file system. This patch replaces the string manipulation used to build
> and reparse option lists with direct QemuOpts calls. Removing the
> string manipulation code makes it easier to maintain and less error
> prone.
>
> An error message is also updated to use "mount_tag" instead of
> "mnt_tag".
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
> v2:
> * Updated error message according to JV's suggestion
>
> vl.c | 56 +++++++++++++++++++-------------------------------------
> 1 files changed, 19 insertions(+), 37 deletions(-)
Please help kill the string manipulation and review + merge this! :)
Stefan
prev parent reply other threads:[~2011-04-26 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 8:31 [Qemu-devel] [PATCH v2] vl.c: Replace -virtfs string manipulation with QemuOpts Stefan Hajnoczi
2011-04-26 13:37 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinzJdrbStS6VP38e8Ff4XMT+44p=Q@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=jvrao@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).