From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QEiSM-0004f8-FW
	for qemu-devel@nongnu.org; Tue, 26 Apr 2011 09:37:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QEiSL-0006jm-7n
	for qemu-devel@nongnu.org; Tue, 26 Apr 2011 09:37:34 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:62039)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QEiSL-0006jh-1E
	for qemu-devel@nongnu.org; Tue, 26 Apr 2011 09:37:33 -0400
Received: by gxk26 with SMTP id 26so274801gxk.4
	for <qemu-devel@nongnu.org>; Tue, 26 Apr 2011 06:37:32 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1300264303-10092-1-git-send-email-stefanha@linux.vnet.ibm.com>
References: <1300264303-10092-1-git-send-email-stefanha@linux.vnet.ibm.com>
Date: Tue, 26 Apr 2011 14:37:32 +0100
Message-ID: <BANLkTinzJdrbStS6VP38e8Ff4XMT+44p=Q@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] vl.c: Replace -virtfs string
 manipulation with QemuOpts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>, qemu-devel@nongnu.org, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>

On Wed, Mar 16, 2011 at 8:31 AM, Stefan Hajnoczi
<stefanha@linux.vnet.ibm.com> wrote:
> The -virtfs option creates an fsdev representing the pass-through file
> system and a guest-visible virtio-9p-pci device that can access this
> file system. =A0This patch replaces the string manipulation used to build
> and reparse option lists with direct QemuOpts calls. =A0Removing the
> string manipulation code makes it easier to maintain and less error
> prone.
>
> An error message is also updated to use "mount_tag" instead of
> "mnt_tag".
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
> v2:
> =A0* Updated error message according to JV's suggestion
>
> =A0vl.c | =A0 56 +++++++++++++++++++-------------------------------------
> =A01 files changed, 19 insertions(+), 37 deletions(-)

Please help kill the string manipulation and review + merge this! :)

Stefan