From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acwCq-0003Tf-KM for qemu-devel@nongnu.org; Mon, 07 Mar 2016 09:32:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acwCn-000063-Ed for qemu-devel@nongnu.org; Mon, 07 Mar 2016 09:32:20 -0500 Received: from mail-io0-x243.google.com ([2607:f8b0:4001:c06::243]:36199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acwCn-00005y-7i for qemu-devel@nongnu.org; Mon, 07 Mar 2016 09:32:17 -0500 Received: by mail-io0-x243.google.com with SMTP id m184so11178594iof.3 for ; Mon, 07 Mar 2016 06:32:16 -0800 (PST) Content-Type: multipart/alternative; boundary="Apple-Mail=_23F9CCC6-2AAB-49D3-B15A-C56970C99163" Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) From: "Huaicheng Li (coperd)" In-Reply-To: Date: Mon, 7 Mar 2016 08:32:15 -0600 Message-Id: References: <56D6033E.2070402@redhat.com> Subject: Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com --Apple-Mail=_23F9CCC6-2AAB-49D3-B15A-C56970C99163 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Mar 5, 2016, at 8:42 PM, Huaicheng Li (coperd) = wrote: >=20 >=20 >> On Mar 1, 2016, at 3:01 PM, Paolo Bonzini > wrote: >>=20 >> This is done >> because the worker threads only care about the queued request list, = not >> about active or completed requests. >=20 > Do you think it would be useful to add an API for inserting one = request back=20 > to the queued list? For example, In case of request failure, we can = insert it=20 > back to the list for re-handling according to some rule before = returning it directly=20 > to guest os.=20 >=20 > Best, > Huaicheng >=20 Thank you for the help.=20= --Apple-Mail=_23F9CCC6-2AAB-49D3-B15A-C56970C99163 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
On Mar 5, 2016, at 8:42 PM, Huaicheng Li (coperd) <lhcwhu@gmail.com> = wrote:


On Mar 1, 2016, at 3:01 PM, Paolo Bonzini <pbonzini@redhat.com>= wrote:

This is done
because the worker threads only care = about the queued request list, not
about active or completed = requests.

Do= you think it would be useful to add an API for inserting one request = back 
to the queued list? For example, In case = of request failure, we can insert it 
back to = the list for re-handling according to some rule before returning it = directly 
to guest os. 

Best,
Huaicheng


Thank you for the help. 
= --Apple-Mail=_23F9CCC6-2AAB-49D3-B15A-C56970C99163--