Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test

["Sebastian Herbszt" <herbszt@gmx.de>]

Gleb Natapov wrote:
> On Mon, Nov 23, 2009 at 12:57:14AM +0100, Carl-Daniel Hailfinger wrote:
>> On 22.11.2009 18:39, Sebastian Herbszt wrote:
>> > Gleb Natapov wrote:
>> >> On Sun, Nov 22, 2009 at 05:51:41PM +0100, Sebastian Herbszt wrote:
>> >>> Is the requirement for "Targeted Content Delivery" specified
>> >>> somewhere with something more
>> >>> clear than "SMBIOS data is useful in identifying the computer for
>> >>> targeted delivery of
>> >>> model-specific software and firmware content" (e.g. changing BIOS
>> >>> version, release date, etc.)?
>> >>>
>> >>> >@@ -130,8 +131,8 @@ smbios_init_type_1(void *start)
>> >>> >    p->header.length = sizeof(struct smbios_type_1);
>> >>> >    p->header.handle = 0x100;
>> >>> >
>> >>> >-    load_str_field_or_skip(1, manufacturer_str);
>> >>> >-    load_str_field_or_skip(1, product_name_str);
>> >>> >+    load_str_field_with_default(1, manufacturer_str, "QEMU");
>> >>> >+    load_str_field_with_default(1, product_name_str, "QEMU");
>> >>>
>> >>> Use "QEMU Virtual Platform" product name derivated from "VMware
>> >>> Virtual Platform" ?
>> >>> Use "QEMU Project" or "QEMU Community" throughout for manufacturer
>> >>> name?
>> >> I'll change this to use defines as per Kevin's request, so to keep
>> >> number of defines to minimum
>> >> lets make it "QEMU Project" everywhere.
>> >
>> > Will you introduce something like CONFIG_SYSVENDOR? Would be useful in
>> > case some other project
>> > (Bochs, Xen?) starts to use seabios.
>> 
>> coreboot already uses SeaBIOS on various x86 hardware platforms.
>> 
> But does coreboot use SMBIOS tables generated by SeaBIOS?

seabios seems to generate SMBIOS tables when used with coreboot.
See coreboot_copy_biostable() in coreboot.c:

    // XXX - just create dummy smbios table for now - should detect if
    // smbios/dmi table is found from coreboot and use that instead.
    smbios_init();

- Sebastian