From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCdFv-0002yq-Da
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 13:03:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCdFq-0002s0-Kx
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 13:03:19 -0500
Received: from [199.232.76.173] (port=47062 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCdFq-0002rk-F0
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 13:03:14 -0500
Received: from mail.gmx.net ([213.165.64.20]:50320)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <herbszt@gmx.de>) id 1NCdFo-0005o0-Fe
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 13:03:13 -0500
Message-ID: <BE208E0FF450449B986A4D6277441FAD@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <20091122140853.GI3193@redhat.com>
	<A3736408F685471D9D2D3864DE814A86@FSCPC>
	<20091122172101.GB9880@redhat.com>
	<38AF5F086DB24529A1D605A0E2414FD0@FSCPC>
	<4B09CFDA.80705@gmx.net> <20091123062849.GA2999@redhat.com>
In-Reply-To: <20091123062849.GA2999@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP
	test
Date: Mon, 23 Nov 2009 19:02:11 +0100
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>, Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Cc: kevin@koconnor.net, qemu-devel@nongnu.org

Gleb Natapov wrote:
> On Mon, Nov 23, 2009 at 12:57:14AM +0100, Carl-Daniel Hailfinger wrote:
>> On 22.11.2009 18:39, Sebastian Herbszt wrote:
>> > Gleb Natapov wrote:
>> >> On Sun, Nov 22, 2009 at 05:51:41PM +0100, Sebastian Herbszt wrote:
>> >>> Is the requirement for "Targeted Content Delivery" specified
>> >>> somewhere with something more
>> >>> clear than "SMBIOS data is useful in identifying the computer for
>> >>> targeted delivery of
>> >>> model-specific software and firmware content" (e.g. changing BIOS
>> >>> version, release date, etc.)?
>> >>>
>> >>> >@@ -130,8 +131,8 @@ smbios_init_type_1(void *start)
>> >>> >    p->header.length = sizeof(struct smbios_type_1);
>> >>> >    p->header.handle = 0x100;
>> >>> >
>> >>> >-    load_str_field_or_skip(1, manufacturer_str);
>> >>> >-    load_str_field_or_skip(1, product_name_str);
>> >>> >+    load_str_field_with_default(1, manufacturer_str, "QEMU");
>> >>> >+    load_str_field_with_default(1, product_name_str, "QEMU");
>> >>>
>> >>> Use "QEMU Virtual Platform" product name derivated from "VMware
>> >>> Virtual Platform" ?
>> >>> Use "QEMU Project" or "QEMU Community" throughout for manufacturer
>> >>> name?
>> >> I'll change this to use defines as per Kevin's request, so to keep
>> >> number of defines to minimum
>> >> lets make it "QEMU Project" everywhere.
>> >
>> > Will you introduce something like CONFIG_SYSVENDOR? Would be useful in
>> > case some other project
>> > (Bochs, Xen?) starts to use seabios.
>> 
>> coreboot already uses SeaBIOS on various x86 hardware platforms.
>> 
> But does coreboot use SMBIOS tables generated by SeaBIOS?

seabios seems to generate SMBIOS tables when used with coreboot.
See coreboot_copy_biostable() in coreboot.c:

    // XXX - just create dummy smbios table for now - should detect if
    // smbios/dmi table is found from coreboot and use that instead.
    smbios_init();

- Sebastian