qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Programmingkid <programmingkidx@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU devel list <qemu-devel@nongnu.org>,
	Akihiko Odaki <akihiko.odaki@gmail.com>
Subject: Re: Picture missing in About dialog on cocoa ui
Date: Thu, 8 Jul 2021 12:23:37 -0400	[thread overview]
Message-ID: <C057B53A-368A-4C9C-9404-230D5FA769ED@gmail.com> (raw)
In-Reply-To: <CAFEAcA-KxyVeKaRPV+A9RkTQGQBoT_LsgyoRH6mON96dTz7uag@mail.gmail.com>



> On Jul 8, 2021, at 4:58 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> 
> On Thu, 8 Jul 2021 at 06:38, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>> 
>> Hi,
>> 
>> My installation correctly shows the picture. Please make sure you
>> install it and run the installed binary (not the binary located in the
>> build directory). The new code should work reliably once you install
>> it while the old code may or may not work depending on how you execute
>> the binary.
> 
> The correct behaviour would be for it to find the icon both
> as an installed binary and when run from the build directory.
> (This is true for various kinds of loaded file including guest
> bios images.)
> 
> thanks
> -- PMM

Agreed. My original code did this. I do think reverting e31746ecf8dd2f25f687c94ac14016a3ba5debfc is the best way to fix this issue.

Thank you.

  reply	other threads:[~2021-07-08 16:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 17:00 Picture missing in About dialog on cocoa ui Programmingkid
2021-07-08  5:37 ` Akihiko Odaki
2021-07-08  8:58   ` Peter Maydell
2021-07-08 16:23     ` Programmingkid [this message]
2021-07-08 16:27   ` Programmingkid
2021-07-08 17:50     ` Peter Maydell
2021-07-08 18:38       ` Programmingkid
2021-08-16 20:55         ` Programmingkid
2021-08-17  8:59           ` Peter Maydell
2021-07-09  0:15       ` Akihiko Odaki
2021-07-10  2:43         ` Programmingkid
2021-07-10  3:30           ` Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C057B53A-368A-4C9C-9404-230D5FA769ED@gmail.com \
    --to=programmingkidx@gmail.com \
    --cc=akihiko.odaki@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).