From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMmZe-0003OA-BS for qemu-devel@nongnu.org; Wed, 18 May 2011 15:38:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QMmZd-0006zf-8C for qemu-devel@nongnu.org; Wed, 18 May 2011 15:38:26 -0400 Received: from cantor.suse.de ([195.135.220.2]:35424 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QMmZc-0006zQ-SP for qemu-devel@nongnu.org; Wed, 18 May 2011 15:38:25 -0400 Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Alexander Graf In-Reply-To: <4DD41AFF.6090604@web.de> Date: Wed, 18 May 2011 21:38:20 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <1305722933-28282-1-git-send-email-agraf@suse.de> <4DD41AFF.6090604@web.de> Subject: Re: [Qemu-devel] [PATCH] ahci: Fix non-NCQ accesses for LBA > 16bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Kevin Wolf , =?iso-8859-1?Q?Ren=E9_Rebe?= , "qemu-devel@nongnu.org Developers" , Alexey Zaytsev On 18.05.2011, at 21:16, Jan Kiszka wrote: > On 2011-05-18 14:48, Alexander Graf wrote: >> AHCI provides two ways of reading/writing data: >> >> 1) NCQ >> 2) ATA commands with the LBA in the command FIS >> >> In the second code path, we didn't handle any LBAs that were bigger than >> 16 bits, so whenever a guest that used high LBA numbers wanted to access >> data, the LBA got truncated down to 16 bits, giving the guest garbage. >> >> This patch adds support for LBAs higher than 16 bits. I've tested that it >> works just fine with SeaBIOS and Linux guests. This patch also unbreaks >> the often reported grub errors people have seen with AHCI. > > Cool! I actually had such a guest as well, but I didn't manage to look > closer so far. Now this patch cures it. Heh, yeah. Only costed me 2 days of my life - sigh :) Alex